third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp - Issue 1944623002: CC Animation: Use ElementId to attach CC animation players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids

Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp

diff --git a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp

index b5a056d37a90622ff5f6e57234f1c444ad8fb8f4..2afc768590689197505e61d3945d74962e14f401 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp

+++ b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp

@@ -38,17 +38,17 @@ void CompositorAnimationPlayer::setAnimationDelegate(CompositorAnimationDelegate

m_animationPlayer->set_animation_delegate(delegate ? this : nullptr);

}

-void CompositorAnimationPlayer::attachLayer(WebLayer* webLayer)

+void CompositorAnimationPlayer::attachElement(CompositorElementId elementId)

{

- m_animationPlayer->AttachElement(webLayer->id());

+ m_animationPlayer->AttachElement(elementId);

}

-void CompositorAnimationPlayer::detachLayer()

+void CompositorAnimationPlayer::detachElement()

{

m_animationPlayer->DetachElement();

}

-bool CompositorAnimationPlayer::isLayerAttached() const

+bool CompositorAnimationPlayer::isElementAttached() const

{

return m_animationPlayer->element_id() != 0;

}