third_party/WebKit/Source/core/animation/Animation.h - Issue 1944623002: CC Animation: Use ElementId to attach CC animation players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids

Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host.cc ('K') | « cc/trees/layer_tree_impl.cc ('k') | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.h

diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h

index 5cfc0539cd8776127dc3f4aa619f55bb4bff24d9..910e900d2671b3e4581a8dd6a82114611b23316e 100644

--- a/third_party/WebKit/Source/core/animation/Animation.h

+++ b/third_party/WebKit/Source/core/animation/Animation.h

@@ -208,8 +208,8 @@ private:

void destroyCompositorPlayer();

void attachCompositorTimeline();

void detachCompositorTimeline();

- void attachCompositedLayers();

- void detachCompositedLayers();

+ void attachCompositorPlayerToElement();

+ void detachCompositorPlayerFromElement();

// CompositorAnimationDelegate implementation.

void notifyAnimationStarted(double monotonicTime, int group) override;

void notifyAnimationFinished(double monotonicTime, int group) override { }