Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids
Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/Animation.cpp
diff --git a/third_party/WebKit/Source/core/animation/Animation.cpp b/third_party/WebKit/Source/core/animation/Animation.cpp
index 863087ae3c4a6637dc0f02ea909ccd11f6ab71ea..6fa10ed5e1225eebe96acb786b1140824aa9d455 100644
--- a/third_party/WebKit/Source/core/animation/Animation.cpp
+++ b/third_party/WebKit/Source/core/animation/Animation.cpp
@@ -909,12 +909,12 @@ void Animation::createCompositorPlayer()
attachCompositorTimeline();
}
- attachCompositedLayers();
+ attachCompositorPlayerToElement();
}
void Animation::destroyCompositorPlayer()
{
- detachCompositedLayers();
+ detachCompositorPlayerFromElement();
if (m_compositorPlayer) {
detachCompositorTimeline();
@@ -941,7 +941,7 @@ void Animation::detachCompositorTimeline()
}
}
-void Animation::attachCompositedLayers()
+void Animation::attachCompositorPlayerToElement()
{
if (!m_compositorPlayer)
return;
@@ -949,14 +949,14 @@ void Animation::attachCompositedLayers()
ASSERT(m_content);
ASSERT(m_content->isKeyframeEffect());
- if (toKeyframeEffect(m_content.get())->canAttachCompositedLayers())
- toKeyframeEffect(m_content.get())->attachCompositedLayers();
+ if (toKeyframeEffect(m_content.get())->canAttachCompositorPlayerToElement())
+ toKeyframeEffect(m_content.get())->attachCompositorPlayerToElement();
}
-void Animation::detachCompositedLayers()
+void Animation::detachCompositorPlayerFromElement()
{
- if (m_compositorPlayer && m_compositorPlayer->isLayerAttached())
- m_compositorPlayer->detachLayer();
+ if (m_compositorPlayer && m_compositorPlayer->isElementAttached())
+ m_compositorPlayer->detachElement();
}
void Animation::notifyAnimationStarted(double monotonicTime, int group)

Powered by Google App Engine
This is Rietveld 408576698