Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1944583002: [MD settings] one way binding for side nav arrow icons (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
michaelpg, dpapad
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] one way binding for side nav arrow icons This CL changes the Polymer binding that controls the arrow style in the side nav menu to use the more efficient one-way binding. BUG=584478 Committed: https://crrev.com/01089137a7646403fb0f7835259a52206a16ecc3 Cr-Commit-Position: refs/heads/master@{#391306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dschuyler
4 years, 7 months ago (2016-05-03 01:32:50 UTC) #2
michaelpg
lgtm. I doubt this is actually more efficient as I'm sure Polymer doesn't even try ...
4 years, 7 months ago (2016-05-03 03:15:46 UTC) #4
dpapad
On 2016/05/03 at 03:15:46, michaelpg wrote: > lgtm. I doubt this is actually more efficient ...
4 years, 7 months ago (2016-05-03 17:03:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944583002/1
4 years, 7 months ago (2016-05-03 18:21:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:25:37 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:28:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01089137a7646403fb0f7835259a52206a16ecc3
Cr-Commit-Position: refs/heads/master@{#391306}

Powered by Google App Engine
This is Rietveld 408576698