chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1944583002: [MD settings] one way binding for side nav arrow icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1944583002: [MD settings] one way binding for side nav arrow icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index 679a02c9efefffae348ddce152aad74348bd4d2f..887b7e8b85176d743a0f1c8d99585ebd42e2c5c9 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -71,7 +71,7 @@

<div class="menu-trigger" data-page="basic" data-section=""

on-tap="openPage_">

- <iron-icon icon="{{arrowState_(basicOpened_)}}" item-icon></iron-icon>

+ <iron-icon icon="[[arrowState_(basicOpened_)]]" item-icon></iron-icon>

</div>

<paper-menu class="menu-content">

@@ -115,7 +115,7 @@

<div class="menu-trigger" data-page="advanced" data-section=""

on-tap="openPage_">

- <iron-icon icon="{{arrowState_(advancedOpened_)}}" item-icon>

+ <iron-icon icon="[[arrowState_(advancedOpened_)]]" item-icon>

</iron-icon>

</div>

<paper-menu class="menu-content">

« no previous file with comments | « no previous file | no next file » | no next file with comments »