Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944413005: More refactoring for Viewer (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
Reviewers:
bsalomon, djsollen
CC:
reviews_skia.org, liyuqian
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More refactoring for Viewer * Move support files into sk_app and main files up to top directory * Rename VulkanTestContext and create WindowContext parent class * Place VulkanWindowContext et al. in sk_app namespace. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1944413005 Committed: https://skia.googlesource.com/skia/+/a8d0d6c8bad00e713bc33e5f0d47ca4fec104433

Patch Set 1 #

Patch Set 2 : Fix up some spacing #

Patch Set 3 : Fix up Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -2461 lines) Patch
D tools/viewer/Application.h View 1 chunk +0 lines, -24 lines 0 comments Download
A + tools/viewer/GMSlide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/GMSlide.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/SKPSlide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/SKPSlide.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/Slide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/Viewer.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/viewer/Viewer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/viewer/VulkanTestContext.h View 1 chunk +0 lines, -114 lines 0 comments Download
D tools/viewer/VulkanTestContext.cpp View 1 chunk +0 lines, -568 lines 0 comments Download
D tools/viewer/Window.h View 1 chunk +0 lines, -150 lines 0 comments Download
D tools/viewer/Window.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D tools/viewer/android/VulkanTestContext_android.h View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/viewer/android/VulkanTestContext_android.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/viewer/android/Window_android.h View 1 chunk +0 lines, -52 lines 0 comments Download
D tools/viewer/android/Window_android.cpp View 1 chunk +0 lines, -183 lines 0 comments Download
D tools/viewer/android/main_android.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
A + tools/viewer/sk_app/Application.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/sk_app/VulkanWindowContext.h View 4 chunks +23 lines, -17 lines 0 comments Download
A + tools/viewer/sk_app/VulkanWindowContext.cpp View 1 17 chunks +40 lines, -37 lines 0 comments Download
A + tools/viewer/sk_app/Window.h View 2 chunks +3 lines, -2 lines 0 comments Download
A + tools/viewer/sk_app/Window.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
A tools/viewer/sk_app/WindowContext.h View 1 chunk +36 lines, -0 lines 0 comments Download
A + tools/viewer/sk_app/android/VulkanWindowContext_android.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
A + tools/viewer/sk_app/android/VulkanWindowContext_android.cpp View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
A + tools/viewer/sk_app/android/Window_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/sk_app/android/Window_android.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/viewer/sk_app/android/main_android.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/sk_app/win/VulkanWindowContext_win.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A + tools/viewer/sk_app/win/VulkanWindowContext_win.cpp View 1 2 chunks +15 lines, -11 lines 0 comments Download
A + tools/viewer/sk_app/win/Window_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/sk_app/win/Window_win.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/viewer/sk_app/win/main_win.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/viewer/viewer/GMSlide.h View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/viewer/viewer/GMSlide.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/viewer/viewer/SKPSlide.h View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/viewer/viewer/SKPSlide.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/viewer/viewer/Slide.h View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/viewer/viewer/Viewer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D tools/viewer/viewer/Viewer.cpp View 1 chunk +0 lines, -346 lines 0 comments Download
D tools/viewer/win/VulkanTestContext_win.h View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/viewer/win/VulkanTestContext_win.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/viewer/win/Window_win.h View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/viewer/win/Window_win.cpp View 1 chunk +0 lines, -285 lines 0 comments Download
D tools/viewer/win/main_win.cpp View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
This should be the last of moving files around for a while.
4 years, 7 months ago (2016-05-05 14:52:13 UTC) #3
bsalomon
lgtm
4 years, 7 months ago (2016-05-05 18:49:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944413005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944413005/40001
4 years, 7 months ago (2016-05-05 19:17:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 19:32:06 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a8d0d6c8bad00e713bc33e5f0d47ca4fec104433

Powered by Google App Engine
This is Rietveld 408576698