Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1944353002: Add GN target for the sample shell (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add GN target for the sample shell I want to stop using d8 from the chromium build, so we could potentially use it for running tests. BUG=chromium:609107 R=machenbach@chromium.org LOG=n Committed: https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8 Cr-Commit-Position: refs/heads/master@{#36060}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M BUILD.gn View 1 2 chunks +33 lines, -0 lines 0 comments Download
M gypfiles/toolchain.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M samples/samples.gyp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-04 13:49:30 UTC) #1
Michael Achenbach
lgtm if comment addressed: https://codereview.chromium.org/1944353002/diff/20001/samples/samples.gyp File samples/samples.gyp (right): https://codereview.chromium.org/1944353002/diff/20001/samples/samples.gyp#newcode66 samples/samples.gyp:66: 'toolsets': [ '<(v8_toolset_for_d8)', ], v8_toolset_for_shell ...
4 years, 7 months ago (2016-05-04 20:02:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944353002/40001
4 years, 7 months ago (2016-05-06 06:39:28 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 07:30:57 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:31:19 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8
Cr-Commit-Position: refs/heads/master@{#36060}

Powered by Google App Engine
This is Rietveld 408576698