Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: samples/samples.gyp

Issue 1944353002: Add GN target for the sample shell (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gypfiles/toolchain.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/samples.gyp
diff --git a/samples/samples.gyp b/samples/samples.gyp
index 78a3ced8b1e87336dc44c75b4a6ec47ef419f8f0..c51250d7252f2ec7ce8f1155550b1c55fbfdc40e 100644
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -29,6 +29,7 @@
'variables': {
'v8_code': 1,
'v8_enable_i18n_support%': 1,
+ 'v8_toolset_for_shell%': 'target',
},
'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],
'target_defaults': {
@@ -60,6 +61,11 @@
'sources': [
'shell.cc',
],
+ 'conditions': [
+ [ 'want_separate_host_toolset==1', {
+ 'toolsets': [ '<(v8_toolset_for_shell)', ],
+ }],
+ ],
},
{
'target_name': 'hello-world',
« no previous file with comments | « gypfiles/toolchain.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698