Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1944043002: Enabled tests to control material design ink drop animations. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Enabled tests to control material design ink drop animations. The InkDropAnimationControllerImpl choreographs the complex interaction of the InkDropAnimations and InkDropHover animations. This interaction relies on internal observations of when the different animations start and finish. This change enables tests to control when these animations start and finish and allow tests to validate states that was previously impossible to inspect when using the ui::ScopedAnimationDurationScaleMode::ZERO_DURATION value. BUG=604415 TEST=InkDropAnimationControllerImplTest.* Review-Url: https://codereview.chromium.org/1913243002 Cr-Commit-Position: refs/heads/master@{#390416} (cherry picked from commit e75c5ce7fa1226bb678850cf6221ce4f503f16ab) Committed: https://chromium.googlesource.com/chromium/src/+/b18931f9693da894c393eafc70febed1e44389c4

Patch Set 1 #

Patch Set 2 : Replaced unique_ptr with scoped_ptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -41 lines) Patch
M ui/views/animation/ink_drop_animation.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 9 chunks +25 lines, -25 lines 0 comments Download
M ui/views/animation/ink_drop_hover.h View 3 chunks +12 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_hover.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 3 chunks +6 lines, -5 lines 0 comments Download
A ui/views/animation/test/ink_drop_hover_test_api.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_hover_test_api.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.cc View 1 2 chunks +80 lines, -8 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 7 months ago (2016-05-03 19:40:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b18931f9693da894c393eafc70febed1e44389c4.

Powered by Google App Engine
This is Rietveld 408576698