Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1913243002: Enabled tests to control material design ink drop animations. (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng, yiyix
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled tests to control material design ink drop animations. The InkDropAnimationControllerImpl choreographs the complex interaction of the InkDropAnimations and InkDropHover animations. This interaction relies on internal observations of when the different animations start and finish. This change enables tests to control when these animations start and finish and allow tests to validate states that was previously impossible to inspect when using the ui::ScopedAnimationDurationScaleMode::ZERO_DURATION value. BUG=604415 TEST=InkDropAnimationControllerImplTest.* Committed: https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab Cr-Commit-Position: refs/heads/master@{#390416}

Patch Set 1 #

Patch Set 2 : Applied patch on top of master instead of 1897073002. #

Patch Set 3 : Added ink_drop_animation_controller_impl_test_api.* files. #

Patch Set 4 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -40 lines) Patch
M ui/views/animation/ink_drop_animation.h View 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation.cc View 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 1 9 chunks +25 lines, -25 lines 0 comments Download
M ui/views/animation/ink_drop_hover.h View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_hover.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h View 2 1 chunk +54 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
A ui/views/animation/test/ink_drop_hover_test_api.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A ui/views/animation/test/ink_drop_hover_test_api.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.cc View 2 chunks +77 lines, -7 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bruthig
sadrul@, can you PTAL?
4 years, 8 months ago (2016-04-22 19:40:13 UTC) #3
bruthig
4 years, 8 months ago (2016-04-26 17:32:34 UTC) #4
sadrul
lgtm
4 years, 7 months ago (2016-04-28 17:00:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913243002/60001
4 years, 7 months ago (2016-04-28 17:01:58 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-28 17:45:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:27 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab
Cr-Commit-Position: refs/heads/master@{#390416}

Powered by Google App Engine
This is Rietveld 408576698