Issue 194403002: PromiseCoerce should ignore primitive values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194403002: PromiseCoerce should ignore primitive values. (Closed)

Created:
6 years, 9 months ago by yhirano

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

PromiseCoerce should ignore primitive values. PromiseCource(x) should return "not a thenable" if Type(x) is not Object even if x.then exists. BUG=347095 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19788

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/promise.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

yhirano

This is needed to pass the Promise/A+ Compliance Test Suite.

6 years, 9 months ago (2014-03-11 06:44:21 UTC) #1

yhirano

Sorry, PS1 is wrong. PS2 Uses IS_SPEC_OBJECT(x) which means "Type(x) is Object".

6 years, 9 months ago (2014-03-11 07:25:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r19788.