src/promise.js - Issue 194403002: PromiseCoerce should ignore primitive values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/promise.js

Issue 194403002: PromiseCoerce should ignore primitive values. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Replacing (typeof x === 'object') with IS_SPEC_OBJECT(x). Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/promise.js

diff --git a/src/promise.js b/src/promise.js

index 82aa99027a1305ac8bf6b95672cccd89504173cd..c5649ef71cfd050bda873f96bb3042ba573db1ff 100644

--- a/src/promise.js

+++ b/src/promise.js

@@ -217,7 +217,7 @@ function PromiseThen(onResolve, onReject) {

PromiseCoerce.table = new $WeakMap;

function PromiseCoerce(constructor, x) {

- if (!(IsPromise(x) || IS_NULL_OR_UNDEFINED(x))) {

+ if (!IsPromise(x) && IS_SPEC_OBJECT(x)) {

var then = x.then;

if (typeof then === 'function') {

if (PromiseCoerce.table.has(x)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »