Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: services/shell/public/cpp/lib/interface_registry.cc

Issue 1943993005: Remove wildcard usage in interface lists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shell/public/cpp/lib/interface_registry.cc
diff --git a/services/shell/public/cpp/lib/interface_registry.cc b/services/shell/public/cpp/lib/interface_registry.cc
index 6ab2401147366bd732fcecc3f46d68a660b40c87..29645c9852137de742c3501740a975a8c8520ee8 100644
--- a/services/shell/public/cpp/lib/interface_registry.cc
+++ b/services/shell/public/cpp/lib/interface_registry.cc
@@ -37,11 +37,11 @@ void InterfaceRegistry::GetInterface(const mojo::String& interface_name,
default_binder_;
if (binder) {
binder->BindInterface(connection_, interface_name, std::move(handle));
- } else {
- LOG(WARNING) << "Connection CapabilityFilter prevented binding to "
- << "interface: " << interface_name << " connection_name:"
- << connection_->GetConnectionName() << " remote_name:"
- << connection_->GetRemoteIdentity().name();
+ } else if (connection_ && !connection_->AllowsInterface(interface_name)) {
+ LOG(ERROR) << "CapabilitySpec of: "
+ << connection_->GetRemoteIdentity().name()
+ << " prevented binding interface: " << interface_name
+ << " provided by: " << connection_->GetConnectionName();
}
}
« no previous file with comments | « services/shell/background/tests/test_catalog_store.cc ('k') | services/shell/tests/connect/connect_test_app_manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698