third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp - Issue 1943993003: Cache hb_font_t and the user data container instead of hb_face_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

Issue 1943993003: Cache hb_font_t and the user data container instead of hb_face_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reset paint flags properly Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp b/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

index 04b7fe6d0388a6592ef9c420410a7972f593d90b..2a461c6a8a234269bb882e81228bc491a6dc8956 100644

--- a/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

@@ -267,10 +267,10 @@ bool FontPlatformData::hasSpaceInLigaturesOrKerning(

if (!hbFace)

return false;

- hb_face_t* face = hbFace->face();

- ASSERT(face);

hb_font_t* font = hbFace->getScaledFont();

ASSERT(font);

+ hb_face_t* face = hb_font_get_face(font);

+ ASSERT(face);

hb_codepoint_t space;

// If the space glyph isn't present in the font then each space character

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp » ('j') | no next file with comments »