third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp - Issue 1943993003: Cache hb_font_t and the user data container instead of hb_face_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp

Issue 1943993003: Cache hb_font_t and the user data container instead of hb_face_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reset paint flags properly Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp

index ad979fc07c5dd12332126ac332fb93e459d4eff5..de00748ea59c8a4a3d943d536de3e1d297ea96f4 100644

--- a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp

+++ b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp

@@ -16,8 +16,7 @@ bool OpenTypeCapsSupport::supportsOpenTypeFeature(

hb_script_t script,

uint32_t tag) const

{

- hb_face_t* face = m_harfBuzzFace->face();

+ hb_face_t* face = hb_font_get_face(m_harfBuzzFace->getScaledFont());

ASSERT(face);

ASSERT((tag == HB_TAG('s', 'm', 'c', 'p')