Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194393002: Implement renderer process side handler of WorkerProcessMsg_CreateWorker message. (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement renderer process side handler of WorkerProcessMsg_CreateWorker message. WorkerProcessMsg_CreateWorker will be sent from the browser process to a renderer process if "enable-embedded-shared-worker" flag is set after https://codereview.chromium.org/154263004/ is landed. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256552

Patch Set 1 #

Total comments: 4

Patch Set 2 : incorporated kinuko's comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/renderer/render_thread_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 5 chunks +14 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
horo
kinuko@ Please review this cl. Thank you.
6 years, 9 months ago (2014-03-11 06:26:06 UTC) #1
kinuko
lgtm https://codereview.chromium.org/194393002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/194393002/diff/1/content/renderer/render_thread_impl.cc#newcode1176 content/renderer/render_thread_impl.cc:1176: IPC_MESSAGE_HANDLER(WorkerProcessMsg_CreateWorker, OnCreateNewSharedWorker) nit: it might be slightly easier ...
6 years, 9 months ago (2014-03-11 07:48:16 UTC) #2
horo
https://codereview.chromium.org/194393002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/194393002/diff/1/content/renderer/render_thread_impl.cc#newcode1176 content/renderer/render_thread_impl.cc:1176: IPC_MESSAGE_HANDLER(WorkerProcessMsg_CreateWorker, OnCreateNewSharedWorker) On 2014/03/11 07:48:17, kinuko wrote: > nit: ...
6 years, 9 months ago (2014-03-11 07:55:56 UTC) #3
horo
jochen@ Could you please review this?
6 years, 9 months ago (2014-03-11 07:56:17 UTC) #4
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/194393002/diff/10001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/194393002/diff/10001/content/renderer/render_thread_impl.cc#newcode1169 content/renderer/render_thread_impl.cc:1169: IPC_MESSAGE_HANDLER(WorkerProcessMsg_CreateWorker, OnCreateNewSharedWorker) it's a bit confusing that the ...
6 years, 9 months ago (2014-03-11 14:33:50 UTC) #5
horo
https://codereview.chromium.org/194393002/diff/10001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/194393002/diff/10001/content/renderer/render_thread_impl.cc#newcode1169 content/renderer/render_thread_impl.cc:1169: IPC_MESSAGE_HANDLER(WorkerProcessMsg_CreateWorker, OnCreateNewSharedWorker) On 2014/03/11 14:33:50, jochen wrote: > it's ...
6 years, 9 months ago (2014-03-12 03:17:06 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-12 03:17:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/194393002/10001
6 years, 9 months ago (2014-03-12 03:21:41 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 16:28:22 UTC) #9
Message was sent while issue was closed. 
Change committed as 256552

Powered by Google App Engine
This is Rietveld 408576698