Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 154263004: Add commandline flag for ServiceWroker in the renderer process. (Closed)

Created:
6 years, 10 months ago by horo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add commandline flag "enable-embedded-shared-worker" for ServiceWroker in the renderer process. This will allow the SharedWorker to run inside the renderer process instead of the worker process. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256421

Patch Set 1 #

Patch Set 2 : Add render_process_host_impl.cc worker_service_impl.cc worker_service.h #

Total comments: 2

Patch Set 3 : incorporated kinuko's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +31 lines, -12 lines 0 comments Download
M content/browser/worker_host/worker_service_impl.cc View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M content/public/browser/worker_service.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
horo
kinuko@ Could you please review this CL?
6 years, 10 months ago (2014-02-10 08:56:01 UTC) #1
kinuko
lgtm
6 years, 10 months ago (2014-02-10 09:00:00 UTC) #2
horo
jochen@ Please review this cl. Thank you.
6 years, 10 months ago (2014-02-10 09:04:46 UTC) #3
jochen (gone - plz use gerrit)
Is it possible to add the flag together with the code that actually uses it? ...
6 years, 10 months ago (2014-02-10 12:23:12 UTC) #4
horo
On 2014/02/10 12:23:12, jochen wrote: > Is it possible to add the flag together with ...
6 years, 10 months ago (2014-02-12 01:48:48 UTC) #5
horo
kinuko@ I added the following files which use this flag. content/browser/renderer_host/render_process_host_impl.cc content/browser/worker_host/worker_service_impl.cc content/public/browser/worker_service.h Could you ...
6 years, 9 months ago (2014-03-11 06:21:27 UTC) #6
kinuko
lgtm https://codereview.chromium.org/154263004/diff/90001/content/browser/worker_host/worker_service_impl.cc File content/browser/worker_host/worker_service_impl.cc (right): https://codereview.chromium.org/154263004/diff/90001/content/browser/worker_host/worker_service_impl.cc#newcode236 content/browser/worker_host/worker_service_impl.cc:236: } nit: no need of { } for ...
6 years, 9 months ago (2014-03-11 07:40:19 UTC) #7
horo
https://codereview.chromium.org/154263004/diff/90001/content/browser/worker_host/worker_service_impl.cc File content/browser/worker_host/worker_service_impl.cc (right): https://codereview.chromium.org/154263004/diff/90001/content/browser/worker_host/worker_service_impl.cc#newcode236 content/browser/worker_host/worker_service_impl.cc:236: } On 2014/03/11 07:40:19, kinuko wrote: > nit: no ...
6 years, 9 months ago (2014-03-11 07:49:19 UTC) #8
horo
jochen@ Could you please review this cl again? I added the following files which use ...
6 years, 9 months ago (2014-03-11 07:51:23 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-11 14:33:45 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-11 15:25:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/154263004/110001
6 years, 9 months ago (2014-03-11 15:26:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 20:29:52 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=279667
6 years, 9 months ago (2014-03-11 20:29:52 UTC) #14
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-11 22:42:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/154263004/110001
6 years, 9 months ago (2014-03-11 22:48:15 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 04:35:38 UTC) #17
Message was sent while issue was closed.
Change committed as 256421

Powered by Google App Engine
This is Rietveld 408576698