Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1943843002: Revert of Make stencils be attachable to render targets created via SkSurface::MakeFromBackendTextureAsRender… (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make stencils be attachable to render targets created via SkSurface::MakeFromBackendTextureAsRender… (patchset #9 id:150001 of https://codereview.chromium.org/1924183003/ ) Reason for revert: Appears to be breaking the roll. Original issue's description: > Make stencils be attachable to render targets created via SkSurface::MakeFromBackendTextureAsRenderTarget > > This is a regression from "Refactor to separate backend object lifecycle > and GpuResource budget decision". > > GrGLRenderTarget::CreateWrapped creates only render targets that wrap > the FBO. > GrGLRenderTargetTexture::CreateWrapped creates render targets that > wrap the texture. > > Use the latter as the implementation for > SkSurface::MakeFromBackendTextureAsRenderTarget. > > > BUG=608238 > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924183003 > > Committed: https://skia.googlesource.com/skia/+/fe635fd76bbc375d527d1884af23cc617ca364ee > > Committed: https://skia.googlesource.com/skia/+/1cb00e42bff455e23f6883bf09680438fa631224 TBR=bsalomon@google.com,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608238 Committed: https://skia.googlesource.com/skia/+/db1adf59890dfd50212ac217eaa2d04e70c0d37c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -180 lines) Patch
M include/core/SkSurface.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +96 lines, -167 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jvanverth1
4 years, 7 months ago (2016-05-03 12:37:37 UTC) #1
Created Revert of Make stencils be attachable to render targets created via
SkSurface::MakeFromBackendTextureAsRender…

Powered by Google App Engine
This is Rietveld 408576698