Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: chrome/browser/printing/print_error_dialog.cc

Issue 194383002: Show dialog as separate post task. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_error_dialog.h ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_error_dialog.cc
diff --git a/chrome/browser/printing/print_error_dialog.cc b/chrome/browser/printing/print_error_dialog.cc
index 5b57b08db83939c148e0a8448b5cbfdc1d9d0ee0..75fdd29896b461cadb630fefd9053460498695dc 100644
--- a/chrome/browser/printing/print_error_dialog.cc
+++ b/chrome/browser/printing/print_error_dialog.cc
@@ -4,17 +4,32 @@
#include "chrome/browser/printing/print_error_dialog.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/simple_message_box.h"
+#include "content/public/browser/browser_thread.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
namespace chrome {
-void ShowPrintErrorDialog(gfx::NativeWindow parent) {
- ShowMessageBox(parent,
+namespace {
+
+void ShowPrintErrorDialogTask() {
+ Browser* browser = chrome::FindLastActiveWithHostDesktopType(
+ chrome::GetActiveDesktop());
+ ShowMessageBox(browser ? browser->window()->GetNativeWindow() : NULL,
l10n_util::GetStringUTF16(IDS_PRINT_SPOOL_FAILED_TITLE_TEXT),
l10n_util::GetStringUTF16(IDS_PRINT_SPOOL_FAILED_ERROR_TEXT),
MESSAGE_BOX_TYPE_WARNING);
}
+} // namespace
+
+void ShowPrintErrorDialog() {
+ // Nested loop may destroy caller.
+ content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+ base::Bind(&ShowPrintErrorDialogTask));
+}
+
} // namespace chrome
« no previous file with comments | « chrome/browser/printing/print_error_dialog.h ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698