Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943723003: Report UNMATCHED_TOKEN instead of EXTRANEOUS_MODIFIER (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report UNMATCHED_TOKEN instead of EXTRANEOUS_MODIFIER Closes #25308 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/3f11e131aedf78f9d4457b7d7b07cec05687c752

Patch Set 1 #

Patch Set 2 : Add test from bug report #

Total comments: 2

Patch Set 3 : Handle ErrorToken in Listener. #

Total comments: 2

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 2 3 3 chunks +12 lines, -3 lines 0 comments Download
A tests/compiler/dart2js/error_token_test.dart View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-03 10:39:29 UTC) #2
ahe
lgtm https://codereview.chromium.org/1943723003/diff/20001/pkg/compiler/lib/src/parser/parser.dart File pkg/compiler/lib/src/parser/parser.dart (right): https://codereview.chromium.org/1943723003/diff/20001/pkg/compiler/lib/src/parser/parser.dart#newcode1004 pkg/compiler/lib/src/parser/parser.dart:1004: if (modifier is ErrorToken) { Modify Listenener.reportError instead.
4 years, 7 months ago (2016-05-03 11:11:38 UTC) #3
Johnni Winther
PTAL https://codereview.chromium.org/1943723003/diff/20001/pkg/compiler/lib/src/parser/parser.dart File pkg/compiler/lib/src/parser/parser.dart (right): https://codereview.chromium.org/1943723003/diff/20001/pkg/compiler/lib/src/parser/parser.dart#newcode1004 pkg/compiler/lib/src/parser/parser.dart:1004: if (modifier is ErrorToken) { On 2016/05/03 11:11:38, ...
4 years, 7 months ago (2016-05-04 08:07:31 UTC) #4
ahe
lgtm https://codereview.chromium.org/1943723003/diff/40001/pkg/compiler/lib/src/parser/listener.dart File pkg/compiler/lib/src/parser/listener.dart (right): https://codereview.chromium.org/1943723003/diff/40001/pkg/compiler/lib/src/parser/listener.dart#newcode558 pkg/compiler/lib/src/parser/listener.dart:558: void reportErrorInternal(Spannable spannable, MessageKind messageKind, This method isn't ...
4 years, 7 months ago (2016-05-04 08:14:58 UTC) #5
Johnni Winther
Committed patchset #4 (id:60001) manually as 3f11e131aedf78f9d4457b7d7b07cec05687c752 (presubmit successful).
4 years, 7 months ago (2016-05-04 11:42:36 UTC) #7
Johnni Winther
4 years, 7 months ago (2016-05-04 11:47:35 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1943723003/diff/40001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/listener.dart (right):

https://codereview.chromium.org/1943723003/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/listener.dart:558: void
reportErrorInternal(Spannable spannable, MessageKind messageKind,
On 2016/05/04 08:14:58, ahe wrote:
> This method isn't necessarily "internal". It's part of the listener API that
you
> should override. Call it "helper" instead?

Done.

Powered by Google App Engine
This is Rietveld 408576698