Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: pkg/compiler/lib/src/parser/listener.dart

Issue 1943723003: Report UNMATCHED_TOKEN instead of EXTRANEOUS_MODIFIER (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | tests/compiler/dart2js/error_token_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/parser/listener.dart
diff --git a/pkg/compiler/lib/src/parser/listener.dart b/pkg/compiler/lib/src/parser/listener.dart
index 1294bf156558ba80a34dffb023460251c8872e34..456cfb180ccb59f5e421f48876bc384db101d042 100644
--- a/pkg/compiler/lib/src/parser/listener.dart
+++ b/pkg/compiler/lib/src/parser/listener.dart
@@ -548,6 +548,15 @@ class Listener {
void reportError(Spannable spannable, MessageKind messageKind,
[Map arguments = const {}]) {
+ if (spannable is ErrorToken) {
+ reportErrorToken(spannable);
+ } else {
+ reportErrorHelper(spannable, messageKind, arguments);
+ }
+ }
+
+ void reportErrorHelper(Spannable spannable, MessageKind messageKind,
+ [Map arguments = const {}]) {
MessageTemplate template = MessageTemplate.TEMPLATES[messageKind];
String message = template.message(arguments, true).toString();
Token token;
@@ -568,7 +577,7 @@ class Listener {
String padding = "0000".substring(hex.length);
hex = "$padding$hex";
}
- reportError(
+ reportErrorHelper(
token, MessageKind.BAD_INPUT_CHARACTER, {'characterHex': hex});
} else if (token is UnterminatedToken) {
MessageKind kind;
@@ -601,11 +610,11 @@ class Listener {
kind = MessageKind.UNTERMINATED_TOKEN;
break;
}
- reportError(token, kind, arguments);
+ reportErrorHelper(token, kind, arguments);
} else if (token is UnmatchedToken) {
String begin = token.begin.value;
String end = closeBraceFor(begin);
- reportError(
+ reportErrorHelper(
token, MessageKind.UNMATCHED_TOKEN, {'begin': begin, 'end': end});
} else {
throw new SpannableAssertionFailure(token, token.assertionMessage);
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | tests/compiler/dart2js/error_token_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698