Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1943703002: 👟 Disable pydeps presumbit on Mac. (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable pydeps presumbit on Mac. On Mac, it fails because "import psutil" does not work (on Linux it exists under /usr/lib/python2.7/dist-packages). BUG=603306 Committed: https://crrev.com/9bc4200b07bf658369e23928a6a5412ea909a149 Cr-Commit-Position: refs/heads/master@{#391534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agrieve
4 years, 7 months ago (2016-05-03 01:25:38 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-04 14:10:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943703002/1
4 years, 7 months ago (2016-05-04 15:58:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 16:33:41 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 16:34:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bc4200b07bf658369e23928a6a5412ea909a149
Cr-Commit-Position: refs/heads/master@{#391534}

Powered by Google App Engine
This is Rietveld 408576698