Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: PRESUBMIT.py

Issue 1943703002: 👟 Disable pydeps presumbit on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 874734e4977c739df019f2d33496260820e4724d..29ae697e322af34aec02e27eb9822b307eb38e76 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1606,8 +1606,9 @@ class PydepsChecker(object):
def _CheckPydepsNeedsUpdating(input_api, output_api, checker_for_tests=None):
"""Checks if a .pydeps file needs to be regenerated."""
# This check is mainly for Android, and involves paths not only in the
- # PRESUBMIT.py, but also in the .pydeps files. Just skip it for Windows.
- if input_api.platform == 'win32':
+ # PRESUBMIT.py, but also in the .pydeps files. It doesn't work on Windows and
+ # Mac, so skip it on other platforms.
+ if input_api.platform != 'linux2':
return []
# TODO(agrieve): Update when there's a better way to detect this: crbug/570091
is_android = input_api.os_path.exists('third_party/android_tools')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698