Makes ash/wm/common a library

Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org

Committed: https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e
Cr-Commit-Position: refs/heads/master@{#391431}

[sky, 2016-05-03 17:05:37]

Description was changed from

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

[sky, 2016-05-03 17:05:37]

sky@chromium.org changed reviewers:
+ garykac@chromium.org, reveman@chromium.org

[sky, 2016-05-03 17:05:54]

+reveman for exo
+garykac for remoting

[James Cook, 2016-05-03 18:43:10]

LGTM with nits

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/aura/wm_lookup_...
File ash/wm/aura/wm_lookup_aura.cc (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/aura/wm_lookup_...
ash/wm/aura/wm_lookup_aura.cc:19: WmLookupAura::~WmLookupAura() {
nit: blank line above

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/BUILD.gn
File ash/wm/common/BUILD.gn (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/BUILD.gn...
ash/wm/common/BUILD.gn:13: component("ash_wm_common") {
optional: Maybe document the purpose of this build target (specifically that
it's trying to avoid aura::Window dependencies, despite assert(use_aura) above)?

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/ash_wm_c...
File ash/wm/common/ash_wm_common_export.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/ash_wm_c...
ash/wm/common/ash_wm_common_export.h:9: // module can
nit: join with next line

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/default_...
File ash/wm/common/default_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/default_...
ash/wm/common/default_window_resizer.h:20: class ASH_WM_COMMON_EXPORT
DefaultWindowResizer : public WindowResizer {
#include for ash_wm_common_export.h, and while you're there probably doesn't
need compiler_specific.h

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/dock/doc...
File ash/wm/common/dock/docked_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/dock/doc...
ash/wm/common/dock/docked_window_resizer.h:26: class ASH_WM_COMMON_EXPORT
DockedWindowResizer : public WindowResizer {
#include ash_wm_common_export.h, maybe doesn't need compiler_specific while
you're there

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/panels/p...
File ash/wm/common/panels/panel_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/panels/p...
ash/wm/common/panels/panel_window_resizer.h:25: class ASH_WM_COMMON_EXPORT
PanelWindowResizer : public WindowResizer {
ditto

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/window_state_au...
File ash/wm/window_state_aura.cc (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/window_state_au...
ash/wm/window_state_aura.cc:17: class WindowStateAura : public wm::WindowState {
Maybe comment on why this has to be here? At first look it's a little weird to
see a do-nothing wrapper class. I presume it's because wm::WindowState doesn't
want to have a public constructor, but has to be constructed outside the DLL?

[reveman, 2016-05-03 18:50:35]

components/exo.gypi lgtm

[sky, 2016-05-03 19:10:06]

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/aura/wm_lookup_...
File ash/wm/aura/wm_lookup_aura.cc (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/aura/wm_lookup_...
ash/wm/aura/wm_lookup_aura.cc:19: WmLookupAura::~WmLookupAura() {
On 2016/05/03 18:43:10, James Cook wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/BUILD.gn
File ash/wm/common/BUILD.gn (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/BUILD.gn...
ash/wm/common/BUILD.gn:13: component("ash_wm_common") {
On 2016/05/03 18:43:10, James Cook wrote:
> optional: Maybe document the purpose of this build target (specifically that
> it's trying to avoid aura::Window dependencies, despite assert(use_aura)
above)?

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/ash_wm_c...
File ash/wm/common/ash_wm_common_export.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/ash_wm_c...
ash/wm/common/ash_wm_common_export.h:9: // module can
On 2016/05/03 18:43:10, James Cook wrote:
> nit: join with next line

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/default_...
File ash/wm/common/default_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/default_...
ash/wm/common/default_window_resizer.h:20: class ASH_WM_COMMON_EXPORT
DefaultWindowResizer : public WindowResizer {
On 2016/05/03 18:43:10, James Cook wrote:
> #include for ash_wm_common_export.h, and while you're there probably doesn't
> need compiler_specific.h

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/dock/doc...
File ash/wm/common/dock/docked_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/dock/doc...
ash/wm/common/dock/docked_window_resizer.h:26: class ASH_WM_COMMON_EXPORT
DockedWindowResizer : public WindowResizer {
On 2016/05/03 18:43:10, James Cook wrote:
> #include ash_wm_common_export.h, maybe doesn't need compiler_specific while
> you're there

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/panels/p...
File ash/wm/common/panels/panel_window_resizer.h (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/common/panels/p...
ash/wm/common/panels/panel_window_resizer.h:25: class ASH_WM_COMMON_EXPORT
PanelWindowResizer : public WindowResizer {
On 2016/05/03 18:43:10, James Cook wrote:
> ditto

Done.

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/window_state_au...
File ash/wm/window_state_aura.cc (right):

https://codereview.chromium.org/1943603002/diff/200001/ash/wm/window_state_au...
ash/wm/window_state_aura.cc:17: class WindowStateAura : public wm::WindowState {
On 2016/05/03 18:43:10, James Cook wrote:
> Maybe comment on why this has to be here? At first look it's a little weird to
> see a do-nothing wrapper class. I presume it's because wm::WindowState doesn't
> want to have a public constructor, but has to be constructed outside the DLL?

Yep. Added comment.

[sky, 2016-05-03 22:31:59]

Description was changed from

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org
==========

[sky, 2016-05-03 22:33:41]

TBR garykac for trivial gyp change

[sky, 2016-05-03 22:33:48]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-03 22:33:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943603002/#ps220001
(title: "feedback")

[commit-bot: I haz the power, 2016-05-03 22:34:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943603002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943603002/220001

[commit-bot: I haz the power, 2016-05-03 22:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 22:42:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-05-03 23:47:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-03 23:47:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943603002/#ps240001
(title: "merge")

[commit-bot: I haz the power, 2016-05-03 23:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943603002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943603002/240001

[commit-bot: I haz the power, 2016-05-04 00:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:06:27]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-05-04 00:09:55]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-04 00:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943603002/#ps260001
(title: "merge")

[commit-bot: I haz the power, 2016-05-04 00:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943603002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943603002/260001

[commit-bot: I haz the power, 2016-05-04 01:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 01:22:24]

Failed to apply the patch.

[sky, 2016-05-04 02:09:39]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-04 02:09:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1943603002/#ps280001
(title: "merge again")

[commit-bot: I haz the power, 2016-05-04 02:10:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943603002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943603002/280001

[commit-bot: I haz the power, 2016-05-04 03:14:17]

Description was changed from

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org
==========

to

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org
==========

[commit-bot: I haz the power, 2016-05-04 03:14:18]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2016-05-04 03:16:18]

Description was changed from

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org
==========

to

==========
Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org

Committed: https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e
Cr-Commit-Position: refs/heads/master@{#391431}
==========

[commit-bot: I haz the power, 2016-05-04 03:16:19]

Patchset 15 (id:??) landed as
https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e
Cr-Commit-Position: refs/heads/master@{#391431}