Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1943503002: Exclude OS X and iOS specific Google Test extensions (Closed)

Created:
4 years, 7 months ago by Petr Hosek
Modified:
4 years, 7 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/build_overrides.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude OS X and iOS specific Google Test extensions We do not have any OS X or iOS specific code in our tests and we do not need such support which would require pulling in additional code from Chromium src/testing. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371 R=mcgrathr@chromium.org Committed: https://chromium.googlesource.com/native_client/src/build_overrides/+/15c436d1cf587aeeedf58463d601371ebea5ff16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M gtest.gni View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Petr Hosek
There's a related change on the Chromium side https://codereview.chromium.org/1941053002/
4 years, 7 months ago (2016-05-02 19:18:29 UTC) #2
Roland McGrath
lgtm once chromium-side change lands
4 years, 7 months ago (2016-05-02 19:22:27 UTC) #3
Petr Hosek
Committed patchset #1 (id:1) manually as 15c436d1cf587aeeedf58463d601371ebea5ff16 (presubmit successful).
4 years, 7 months ago (2016-05-02 23:59:09 UTC) #5
Petr Hosek
4 years, 7 months ago (2016-05-03 17:43:48 UTC) #6
Message was sent while issue was closed.
You're right, that was my mistake.

Powered by Google App Engine
This is Rietveld 408576698