Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1941053002: Allow excluding OS X and iOS specific Google Test extensions (Closed)

Created:
4 years, 7 months ago by Petr Hosek
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow excluding OS X and iOS specific Google Test extensions GN build of Google Test includes extensions that are used for testing Chromium on OS X and iOS. These are not needed by external projects that want to reuse the GN build definition for Google Test. Committed: https://crrev.com/e3b485ba6a3af510ab17925f403595f402568544 Cr-Commit-Position: refs/heads/master@{#391103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/secondary/testing/gtest/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build_overrides/gtest.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Petr Hosek
4 years, 7 months ago (2016-05-02 19:16:40 UTC) #3
Roland McGrath
lgtm
4 years, 7 months ago (2016-05-02 19:22:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941053002/1
4 years, 7 months ago (2016-05-02 21:33:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176264)
4 years, 7 months ago (2016-05-02 21:40:53 UTC) #9
Petr Hosek
Seems like I need an lgtm from Dirk.
4 years, 7 months ago (2016-05-02 21:45:51 UTC) #10
Petr Hosek
Seems like I need an lgtm from Dirk.
4 years, 7 months ago (2016-05-02 21:46:03 UTC) #11
Petr Hosek
Seems like I need an lgtm from Dirk.
4 years, 7 months ago (2016-05-02 21:46:05 UTC) #12
Dirk Pranke
lgtm. Maybe send a PSA out on gn-dev@ so that other people who own other ...
4 years, 7 months ago (2016-05-02 23:37:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941053002/1
4 years, 7 months ago (2016-05-02 23:39:58 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 23:47:30 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:48:37 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b485ba6a3af510ab17925f403595f402568544
Cr-Commit-Position: refs/heads/master@{#391103}

Powered by Google App Engine
This is Rietveld 408576698