Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fwl/core/fwl_error.h

Issue 1943413002: Convert FWL_ERR into an enum class. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@bcdattribute
Patch Set: Mac XFA build Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp ('K') | « xfa/fwl/core/fwl_appimp.cpp ('k') | xfa/fwl/core/fwl_formimp.h » ('j') | xfa/fxfa/app/xfa_fffield.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/fwl_error.h
diff --git a/xfa/fwl/core/fwl_error.h b/xfa/fwl/core/fwl_error.h
index 92a483f4e8c34cc5b5ea0e866c8b0883658e57e2..e29f89e012968558bb7f3d3b11343c15c7e82a3a 100644
--- a/xfa/fwl/core/fwl_error.h
+++ b/xfa/fwl/core/fwl_error.h
@@ -7,16 +7,14 @@
#ifndef XFA_FWL_CORE_FWL_ERROR_H_
#define XFA_FWL_CORE_FWL_ERROR_H_
-#include <stdint.h>
-
-typedef int32_t FWL_ERR;
-
-#define FWL_ERR_Succeeded 0
-#define FWL_ERR_Indefinite -1
-#define FWL_ERR_Parameter_Invalid -100
-#define FWL_ERR_Property_Invalid -200
-#define FWL_ERR_Intermediate_Value__Invalid -300
-#define FWL_ERR_Method_Not_Supported -400
-#define FWL_ERR_Out_Of_Memory -500
+enum class FWL_Error {
+ Succeeded = 0,
+ Indefinite,
+ ParameterInvalid,
+ PropertyInvalid,
+ IntermediateValueInvalid,
+ MethodNotSupported,
+ OutOfMemory
+};
#endif // XFA_FWL_CORE_FWL_ERROR_H_
« xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp ('K') | « xfa/fwl/core/fwl_appimp.cpp ('k') | xfa/fwl/core/fwl_formimp.h » ('j') | xfa/fxfa/app/xfa_fffield.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698