Convert FWL_ERR into an enum class.

xfa/fxfa/app/xfa_fffield.cpp

Index: xfa/fxfa/app/xfa_fffield.cpp
diff --git a/xfa/fxfa/app/xfa_fffield.cpp b/xfa/fxfa/app/xfa_fffield.cpp
index 873658a9157519be6c6562a7efa76a7c00de20d4..415e67bda362aebf6041484f66c2082a3ae52ca7 100644
--- a/xfa/fxfa/app/xfa_fffield.cpp
+++ b/xfa/fxfa/app/xfa_fffield.cpp
@@ -790,10 +790,10 @@ void CXFA_FFField::TranslateFWLMessage(CFWL_Message* pMessage) {
   GetApp()->GetWidgetMgrDelegate()->OnProcessMessageToForm(pMessage);
 }
 int32_t CXFA_FFField::OnProcessMessage(CFWL_Message* pMessage) {

[Tom Sepez, 2016/05/03 18:19:41]

Maybe this should return FWL_Error for consistency with other on*

[dsinclair, 2016/05/03 19:29:51]

Return value is never checked. Make the three On methods return void.

-  return FWL_ERR_Succeeded;
+  return 0;
 }
 
-FWL_ERR CXFA_FFField::OnProcessEvent(CFWL_Event* pEvent) {
+FWL_Error CXFA_FFField::OnProcessEvent(CFWL_Event* pEvent) {
   switch (pEvent->GetClassID()) {
     case CFWL_EventType::Mouse: {
       CFWL_EvtMouse* event = (CFWL_EvtMouse*)pEvent;
@@ -830,10 +830,10 @@ FWL_ERR CXFA_FFField::OnProcessEvent(CFWL_Event* pEvent) {
     default:
       break;
   }
-  return FWL_ERR_Succeeded;
+  return FWL_Error::Succeeded;
 }
 
-FWL_ERR CXFA_FFField::OnDrawWidget(CFX_Graphics* pGraphics,
-                                   const CFX_Matrix* pMatrix) {
-  return FWL_ERR_Succeeded;
+FWL_Error CXFA_FFField::OnDrawWidget(CFX_Graphics* pGraphics,
+                                     const CFX_Matrix* pMatrix) {
+  return FWL_Error::Succeeded;
 }