Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943413002: Convert FWL_ERR into an enum class. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@bcdattribute
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert FWL_ERR into an enum class. This Cl updates FWL_ERR to be an FWL_Error enum class. It removes FX_ERR and replaces it with FWL_Error as well as the values were the same. There were many places where we either returned other values for FWL_ERR results or returned FWL_ERR results for other values. Those have all been cleaned up.

Patch Set 1 #

Patch Set 2 : Mac XFA build #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : Rebase to master #

Total comments: 2

Patch Set 5 : Rebase to master #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3082 lines, -3034 lines) Patch
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 2 5 chunks +21 lines, -21 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.h View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 1 2 6 chunks +41 lines, -40 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.h View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 1 2 9 chunks +31 lines, -32 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.h View 1 2 3 9 chunks +42 lines, -42 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 1 2 3 4 5 42 chunks +131 lines, -124 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.h View 1 2 3 9 chunks +38 lines, -38 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 1 2 3 25 chunks +127 lines, -121 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.h View 1 2 3 3 chunks +38 lines, -36 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 2 3 4 19 chunks +183 lines, -140 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.cpp View 1 2 2 chunks +16 lines, -14 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.h View 1 2 3 3 chunks +15 lines, -17 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 1 2 3 4 13 chunks +51 lines, -71 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 1 2 6 chunks +22 lines, -26 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.h View 1 2 2 chunks +10 lines, -9 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.cpp View 1 2 4 chunks +24 lines, -21 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.h View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.cpp View 1 2 6 chunks +29 lines, -31 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.h View 1 2 2 chunks +17 lines, -17 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 2 8 chunks +44 lines, -48 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.h View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 2 3 9 chunks +28 lines, -30 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.h View 1 2 2 chunks +16 lines, -16 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 2 7 chunks +51 lines, -44 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_caret.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_combobox.h View 2 chunks +12 lines, -12 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_datetimepicker.h View 3 chunks +14 lines, -14 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_edit.h View 2 chunks +23 lines, -23 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_listbox.h View 1 2 3 chunks +26 lines, -28 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_picturebox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_scrollbar.h View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_spinbutton.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_tooltip.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_event.h View 2 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/core/cfwl_message.h View 2 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/core/fwl_appimp.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_appimp.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/core/fwl_error.h View 1 chunk +9 lines, -11 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 1 2 3 4 2 chunks +15 lines, -15 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 2 3 15 chunks +47 lines, -52 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 3 chunks +13 lines, -13 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 2 3 4 13 chunks +43 lines, -42 lines 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.h View 2 chunks +41 lines, -41 lines 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.cpp View 3 chunks +81 lines, -77 lines 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 2 3 2 chunks +35 lines, -33 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 2 3 20 chunks +101 lines, -105 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.h View 1 2 3 4 3 chunks +28 lines, -28 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 1 2 3 4 8 chunks +50 lines, -52 lines 0 comments Download
M xfa/fwl/core/ifwl_adapterwidgetmgr.h View 1 chunk +44 lines, -44 lines 0 comments Download
M xfa/fwl/core/ifwl_app.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_dataprovider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_themeprovider.h View 1 chunk +6 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_timer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_tooltiptarget.h View 1 chunk +8 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 2 3 1 chunk +27 lines, -25 lines 0 comments Download
M xfa/fwl/core/ifwl_widgetdelegate.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_widgetmgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/include/ifwl_adaptertimermgr.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_barcode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_barcode.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_checkbox.h View 2 chunks +7 lines, -6 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_checkbox.cpp View 2 chunks +14 lines, -13 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.h View 4 chunks +43 lines, -43 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.cpp View 13 chunks +68 lines, -67 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.h View 3 chunks +16 lines, -15 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.cpp View 6 chunks +25 lines, -25 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.h View 1 chunk +23 lines, -23 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.cpp View 6 chunks +45 lines, -45 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.h View 1 2 4 chunks +35 lines, -36 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.cpp View 1 2 9 chunks +68 lines, -70 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_picturebox.h View 2 chunks +12 lines, -11 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_picturebox.cpp View 3 chunks +27 lines, -26 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_pushbutton.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_pushbutton.cpp View 1 chunk +14 lines, -13 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_scrollbar.h View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_scrollbar.cpp View 6 chunks +17 lines, -17 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_theme.h View 1 chunk +10 lines, -10 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_theme.cpp View 3 chunks +16 lines, -15 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_tooltip.h View 1 chunk +20 lines, -13 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_tooltip.cpp View 2 chunks +20 lines, -26 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.h View 1 2 3 2 chunks +27 lines, -25 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.cpp View 1 2 3 11 chunks +60 lines, -60 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widgetdelegate.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widgetdelegate.cpp View 1 2 1 chunk +6 lines, -12 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_formtp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_formtp.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 1 chunk +16 lines, -16 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 1 2 3 4 4 chunks +30 lines, -30 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 2 4 chunks +16 lines, -14 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 2 3 2 chunks +4 lines, -9 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 2 5 chunks +17 lines, -14 lines 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 2 chunks +14 lines, -14 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 8 chunks +19 lines, -20 lines 0 comments Download
M xfa/fxgraphics/cagg_graphics.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxgraphics/cagg_graphics.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/fxgraphics/cfx_color.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxgraphics/cfx_color.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 23 chunks +249 lines, -242 lines 0 comments Download
M xfa/fxgraphics/cfx_path.h View 1 chunk +48 lines, -48 lines 0 comments Download
M xfa/fxgraphics/cfx_path.cpp View 1 chunk +83 lines, -81 lines 0 comments Download
M xfa/fxgraphics/include/cfx_graphics.h View 3 chunks +102 lines, -109 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dsinclair
PTAL. This is large, but you probably don't want to rubber stamp as it wasn't ...
4 years, 7 months ago (2016-05-03 15:26:51 UTC) #2
Tom Sepez
https://codereview.chromium.org/1943413002/diff/20001/xfa/fwl/basewidget/fwl_listboximp.cpp File xfa/fwl/basewidget/fwl_listboximp.cpp (left): https://codereview.chromium.org/1943413002/diff/20001/xfa/fwl/basewidget/fwl_listboximp.cpp#oldcode315 xfa/fwl/basewidget/fwl_listboximp.cpp:315: FWL_ERR* CFWL_ListBoxImp::Sort(IFWL_ListBoxCompare* pCom) { nice. presumably success == 0, ...
4 years, 7 months ago (2016-05-03 18:19:41 UTC) #3
dsinclair
https://codereview.chromium.org/1943413002/diff/20001/xfa/fwl/basewidget/fwl_listboximp.cpp File xfa/fwl/basewidget/fwl_listboximp.cpp (left): https://codereview.chromium.org/1943413002/diff/20001/xfa/fwl/basewidget/fwl_listboximp.cpp#oldcode315 xfa/fwl/basewidget/fwl_listboximp.cpp:315: FWL_ERR* CFWL_ListBoxImp::Sort(IFWL_ListBoxCompare* pCom) { On 2016/05/03 18:19:41, Tom Sepez ...
4 years, 7 months ago (2016-05-03 19:29:51 UTC) #4
dsinclair
ping
4 years, 7 months ago (2016-05-04 14:03:44 UTC) #5
Tom Sepez
lgtm https://codereview.chromium.org/1943413002/diff/60001/xfa/fwl/basewidget/fwl_comboboximp.cpp File xfa/fwl/basewidget/fwl_comboboximp.cpp (right): https://codereview.chromium.org/1943413002/diff/60001/xfa/fwl/basewidget/fwl_comboboximp.cpp#newcode172 xfa/fwl/basewidget/fwl_comboboximp.cpp:172: if (!backDefault) nit: or just: if (backDefault) CFWL_....();
4 years, 7 months ago (2016-05-04 20:40:14 UTC) #6
dsinclair
https://codereview.chromium.org/1943413002/diff/60001/xfa/fwl/basewidget/fwl_comboboximp.cpp File xfa/fwl/basewidget/fwl_comboboximp.cpp (right): https://codereview.chromium.org/1943413002/diff/60001/xfa/fwl/basewidget/fwl_comboboximp.cpp#newcode172 xfa/fwl/basewidget/fwl_comboboximp.cpp:172: if (!backDefault) On 2016/05/04 20:40:14, Tom Sepez wrote: > ...
4 years, 7 months ago (2016-05-04 21:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943413002/100001
4 years, 7 months ago (2016-05-04 21:13:41 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 21:13:44 UTC) #12 
CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

Powered by Google App Engine
This is Rietveld 408576698