Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1943223002: Web Animations: Add AnimationEffectTimingProperties IDL dictionary (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_nullableNull
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add AnimationEffectTimingProperties IDL dictionary This change adds the AnimationEffectTimingProperties IDL definition. http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dictionary This brings our internal representation of Web Animation interfaces closer to the spec. There are no behavioural changes made by this patch. BUG=600248 Committed: https://crrev.com/107c2dd4bab61ff1876daccc56f40a8436dfdf10 Cr-Commit-Position: refs/heads/master@{#392563}

Patch Set 1 #

Patch Set 2 : git add -A #

Patch Set 3 : https #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
A third_party/WebKit/Source/core/animation/AnimationEffectTimingProperties.idl View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ComputedTimingProperties.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectOptions.idl View 1 2 1 chunk +4 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (8 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-05-03 08:53:55 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 7 months ago (2016-05-03 23:41:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943223002/40001
4 years, 7 months ago (2016-05-05 04:25:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/216689)
4 years, 7 months ago (2016-05-05 05:36:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943223002/40001
4 years, 7 months ago (2016-05-06 02:57:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/178646)
4 years, 7 months ago (2016-05-06 03:03:57 UTC) #11
alancutter (OOO until 2018)
+timloh for core.gypi change.
4 years, 7 months ago (2016-05-06 03:05:35 UTC) #12
Timothy Loh
On 2016/05/06 03:05:35, alancutter wrote: > +timloh for core.gypi change. lgtm
4 years, 7 months ago (2016-05-10 05:29:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943223002/40001
4 years, 7 months ago (2016-05-10 06:50:57 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 07:49:02 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 07:50:23 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/107c2dd4bab61ff1876daccc56f40a8436dfdf10
Cr-Commit-Position: refs/heads/master@{#392563}

Powered by Google App Engine
This is Rietveld 408576698