Transfer theme & page background colors between changes of RWHV.

Transfer theme & page background colors between changes of RWHV.

When transitioning to a new RenderWidgetHostView, copy the current background
color of the previous one. When putting up a frame in an active 
RenderWidgetHostView, set the background color to the background reported by
the renderer process's compositor.

This allows us to transition between web pages which have background colors A
and B without a flash of white (or the theme color, which may be neither A nor B).

BUG=470669

[chrishtr, 2016-05-03 04:13:48]

Description was changed from

==========
none


none


none


Merge branch 'noflash' into pagebackground


none


none


none

BUG=
==========

to

==========
Transfer theme & page background colors between changes of RWHV.

When transitioning to a new RenderWidgetHostView, copy the current background
color of the previous one. When putting up a frame in an active 
RenderWidgetHostView, set the background color to the background reported by
the renderer process's compositor.

This allows us to transition between web pages which have background colors A
and B without a flash of white (or the theme color, which may be neither A nor
B).

BUG=470669
==========

[chrishtr, 2016-05-03 04:18:17]

chrishtr@chromium.org changed reviewers:
+ sievers@chromium.org

[chrishtr, 2016-05-04 18:45:34]

chrishtr@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-05-04 20:39:09]

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/contents_web_view.cc (right):

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/contents_web_view.cc:140: if (old_host &&
new_host)
If this is the right change, can't we do it entirely in content?

[chrishtr, 2016-05-04 21:10:19]

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/contents_web_view.cc (right):

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/contents_web_view.cc:140: if (old_host &&
new_host)
On 2016/05/04 at 20:39:09, sky wrote:
> If this is the right change, can't we do it entirely in content?

I'm not sure what you mean. What do you mean by "in content"?

[sky, 2016-05-04 21:48:06]

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/contents_web_view.cc (right):

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/contents_web_view.cc:140: if (old_host &&
new_host)
On 2016/05/04 21:10:18, chrishtr wrote:
> On 2016/05/04 at 20:39:09, sky wrote:
> > If this is the right change, can't we do it entirely in content?
> 
> I'm not sure what you mean. What do you mean by "in content"?

Content knows when the renderframehost is changing (content is calling this
code). I'm suggesting this code be moved there.

[chrishtr, 2016-05-04 23:07:16]

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/contents_web_view.cc (right):

https://codereview.chromium.org/1943183002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/contents_web_view.cc:140: if (old_host &&
new_host)
On 2016/05/04 at 21:48:06, sky wrote:
> On 2016/05/04 21:10:18, chrishtr wrote:
> > On 2016/05/04 at 20:39:09, sky wrote:
> > > If this is the right change, can't we do it entirely in content?
> > 
> > I'm not sure what you mean. What do you mean by "in content"?
> 
> Content knows when the renderframehost is changing (content is calling this
code). I'm suggesting this code be moved there.

Done (hope I understood your suggestion).

Should the same be done for RenderViewReady()?

[chrishtr, 2016-05-04 23:07:21]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 23:07:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943183002/60001

[commit-bot: I haz the power, 2016-05-04 23:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 23:31:05]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sky, 2016-05-05 15:28:18]

This is what I was asking. I'm not an owner of content though, so you'll need to
get someone else to review.

[chrishtr, 2016-05-05 15:33:50]

chrishtr@chromium.org changed reviewers:
+ sadrul@chromium.org

[no sievers, 2016-05-17 18:05:43]

https://codereview.chromium.org/1943183002/diff/60001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1943183002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3919:
old_host->GetView()->background_color());
You said this doesn't work reliably. Does it work better if you set the color
from RenderFrameHostManager::Navigate() where we call
delegate_->CreateRenderViewForRenderManager()?

The other way to make this a bit more robust would be to make the
background_color a property of the WebContentsView and then
WebContentsView::CreateViewForWidget() could set the right background color
immediately.

[chrishtr, 2016-05-17 21:26:33]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-05-17 21:26:37]

The CQ bit was unchecked by chrishtr@chromium.org