Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 1939913002: Use the NTP background color instead of white when there is no other info. (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the NTP background color instead of white when there is no other info. To do this, observe the RenderViewReady callback in ContentsWebView. BUG=470669 Committed: https://crrev.com/dd94ab1cdce9d3b0e45d8b4689d0b4865fb2d942 Cr-Commit-Position: refs/heads/master@{#391081}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/contents_web_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_web_view.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
chrishtr
4 years, 7 months ago (2016-05-02 18:52:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939913002/40001
4 years, 7 months ago (2016-05-02 18:53:18 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 19:44:43 UTC) #7
sky
LGTM https://codereview.chromium.org/1939913002/diff/40001/chrome/browser/ui/views/frame/contents_web_view.cc File chrome/browser/ui/views/frame/contents_web_view.cc (right): https://codereview.chromium.org/1939913002/diff/40001/chrome/browser/ui/views/frame/contents_web_view.cc#newcode72 chrome/browser/ui/views/frame/contents_web_view.cc:72: if (rwhv) nit: move inside if block on ...
4 years, 7 months ago (2016-05-02 20:04:33 UTC) #8
chrishtr
https://codereview.chromium.org/1939913002/diff/40001/chrome/browser/ui/views/frame/contents_web_view.cc File chrome/browser/ui/views/frame/contents_web_view.cc (right): https://codereview.chromium.org/1939913002/diff/40001/chrome/browser/ui/views/frame/contents_web_view.cc#newcode72 chrome/browser/ui/views/frame/contents_web_view.cc:72: if (rwhv) On 2016/05/02 at 20:04:33, sky wrote: > ...
4 years, 7 months ago (2016-05-02 20:24:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939913002/60001
4 years, 7 months ago (2016-05-02 20:24:28 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-02 22:47:21 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:48:41 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dd94ab1cdce9d3b0e45d8b4689d0b4865fb2d942
Cr-Commit-Position: refs/heads/master@{#391081}

Powered by Google App Engine
This is Rietveld 408576698