Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1943163002: Do not use lld to link NaCl binaries. (Closed)

Created:
4 years, 7 months ago by pcc1
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use lld to link NaCl binaries. The NaCl toolchain does not know how to find lld. (Besides, lld does not have support for NaCl.) BUG=607968 R=brettw@chromium.org Committed: https://crrev.com/cbb9923180edc9297292e746cae996630f1cd867 Cr-Commit-Position: refs/heads/master@{#391182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
4 years, 7 months ago (2016-05-03 01:13:33 UTC) #1
brettw
lgtm
4 years, 7 months ago (2016-05-03 05:53:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943163002/1
4 years, 7 months ago (2016-05-03 06:53:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 07:44:31 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 07:50:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbb9923180edc9297292e746cae996630f1cd867
Cr-Commit-Position: refs/heads/master@{#391182}

Powered by Google App Engine
This is Rietveld 408576698