Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 1943163002: Do not use lld to link NaCl binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index ae65d4ea9055333042d7e73d4a5aac6d3d6ca1e0..cedd5faeac6ca7d8f0eae8170a7d6c4a4228c79e 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -293,7 +293,7 @@ config("compiler") {
# Linux-specific compiler flags setup.
# ------------------------------------
- if (is_posix && use_lld) {
+ if (is_posix && use_lld && !is_nacl) {
ldflags += [ "-fuse-ld=lld" ]
} else if (use_gold) {
ldflags += [
@@ -331,7 +331,7 @@ config("compiler") {
ldflags += [ "-fuse-ld=bfd" ]
}
- if (is_posix && (use_gold || use_lld) && !using_sanitizer &&
+ if (is_posix && (use_gold || (use_lld && !is_nacl)) && !using_sanitizer &&
!(is_android && use_order_profiling)) {
ldflags += [ "-Wl,--icf=all" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698