Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1943103002:
Recompile .rc files when manifests change in GN. (Closed)
DescriptionRecompile .rc files when manifests change in GN.
Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds.
BUG=608228
Committed: https://crrev.com/30eadcf8a08630d39c3df6001834572ef4f1932f
Cr-Commit-Position: refs/heads/master@{#391131}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
brettw@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943103002/1
BUG=? We should probably file one to note that .rc's don't work in general if not. lgtm
On 2016/05/02 23:38:48, scottmg wrote: > BUG=? > > We should probably file one to note that .rc's don't work in general if not. > > lgtm I guess at least 608228.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm also, and yup, that's the bug to use.
Description was changed from ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. ========== to ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. BUG=608228 ==========
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943103002/1
Message was sent while issue was closed.
Description was changed from ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. BUG=608228 ========== to ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. BUG=608228 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. BUG=608228 ========== to ========== Recompile .rc files when manifests change in GN. Previously changes in the .manifest file would not cause the .rc file that references it to recompile, giving stale builds. BUG=608228 Committed: https://crrev.com/30eadcf8a08630d39c3df6001834572ef4f1932f Cr-Commit-Position: refs/heads/master@{#391131} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30eadcf8a08630d39c3df6001834572ef4f1932f Cr-Commit-Position: refs/heads/master@{#391131} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
