Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942903002: build: sanitize non-alpha characters in builder cache path (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
borenet2
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

build: sanitize non-alpha characters in builder cache path BUG=chromium:596887 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Kitchen__kitchen_run_.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/kitchen_path_config.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
borenet2
LGTM. It seems surprising to me that these builder names are allowed at all...
4 years, 7 months ago (2016-05-02 17:10:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942903002/1
4 years, 7 months ago (2016-05-02 17:10:55 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:15:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300408

Powered by Google App Engine
This is Rietveld 408576698