Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 1942903002: build: sanitize non-alpha characters in builder cache path (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Kitchen__kitchen_run_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 3544e174aafef717874cd2605b9683494fa450ef..c8f7348a8b02f04b7e07f57e05c33dc76c6c8945 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -100,7 +100,9 @@ class ChromiumApi(recipe_api.RecipeApi):
"""Return the path to the build executable directory."""
build_dir = self.c.build_dir
if self.c.use_build_dir_cache:
- build_dir = build_dir.join(self.m.properties['buildername'])
+ sanitized_buildername = ''.join(c if c.isalnum() else '_'
+ for c in self.m.properties['buildername'])
+ build_dir = build_dir.join(sanitized_buildername)
return self.m.path.join(build_dir, target or self.c.build_config_fs)
@property
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Kitchen__kitchen_run_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698