[Devtools] isTrusted in CustomEvents shown twice in console

[Devtools] isTrusted in CustomEvents shown twice in console

Fixed bug where isTrusted would show up twice in console when custom
events were expanded. Caused because isTrusted is Unforgable which
makes it both OwnProperty always and an AccessorProperty.

BUG=607819
R=lushnikov

Committed: https://crrev.com/7baaeba8ef926e8c82f4d03d41a8a1045829a51f
Cr-Commit-Position: refs/heads/master@{#391049}

[allada, 2016-05-02 17:17:57]

Patchset #1 (id:1) has been deleted

[allada, 2016-05-02 17:19:39]

PTL

[lushnikov, 2016-05-02 18:38:20]

lgtm

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/console/console-dir.html (right):

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-dir.html:41: //
document.createEvent("Event") has a special property "isTrusted" flagged
"Unforgeable"
style: comments should end with "."

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:992: if
(!property.isAccessorProperty()) {
if (property.isAccessorProperty())
    continue;

to decrease code nesting

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:999: return
callback(propertySymbols.concat(propertiesMap.valuesArray()),
savedInternalProperties ? savedInternalProperties : null);
will this display symbols in the very beginning of the list?

I'd rather leave Symbols in the end of property list. Could you please add a
symbol test
while we're here?

[allada, 2016-05-02 19:06:13]

Done

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/console/console-dir.html (right):

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-dir.html:41: //
document.createEvent("Event") has a special property "isTrusted" flagged
"Unforgeable"
On 2016/05/02 18:38:19, lushnikov wrote:
> style: comments should end with "."

Done.

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:992: if
(!property.isAccessorProperty()) {
On 2016/05/02 18:38:20, lushnikov wrote:
> if (property.isAccessorProperty())
>     continue;
> 
> to decrease code nesting

Done.

https://codereview.chromium.org/1942883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:999: return
callback(propertySymbols.concat(propertiesMap.valuesArray()),
savedInternalProperties ? savedInternalProperties : null);
On 2016/05/02 18:38:19, lushnikov wrote:
> will this display symbols in the very beginning of the list?
> 
> I'd rather leave Symbols in the end of property list. Could you please add a
> symbol test
> while we're here?

Done. This list gets sorted later anyway and We already have a few symbol tests
in place in some ES6 tests.

[allada, 2016-05-02 19:21:25]

The CQ bit was checked by allada@chromium.org

[allada, 2016-05-02 19:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1942883002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-02 19:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942883002/40001

[commit-bot: I haz the power, 2016-05-02 21:00:18]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-02 21:02:00]

Description was changed from

==========
[Devtools] isTrusted in CustomEvents shown twice in console

Fixed bug where isTrusted would show up twice in console when custom
events were expanded. Caused because isTrusted is Unforgable which
makes it both OwnProperty always and an AccessorProperty.

BUG=607819
R=lushnikov
==========

to

==========
[Devtools] isTrusted in CustomEvents shown twice in console

Fixed bug where isTrusted would show up twice in console when custom
events were expanded. Caused because isTrusted is Unforgable which
makes it both OwnProperty always and an AccessorProperty.

BUG=607819
R=lushnikov

Committed: https://crrev.com/7baaeba8ef926e8c82f4d03d41a8a1045829a51f
Cr-Commit-Position: refs/heads/master@{#391049}
==========

[commit-bot: I haz the power, 2016-05-02 21:02:01]

Patchset 2 (id:??) landed as
https://crrev.com/7baaeba8ef926e8c82f4d03d41a8a1045829a51f
Cr-Commit-Position: refs/heads/master@{#391049}