Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1942883002: [Devtools] isTrusted in CustomEvents shown twice in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index bba2c6e5f6d1dfe3da730ee0fc25a806ba2bb48f..905d050a99d14ed3998d4c08ef28ae22149d2614 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -978,13 +978,25 @@ WebInspector.RemoteObject.loadFromObjectPerProto = function(object, callback)
if (--resultCounter)
return;
if (savedOwnProperties && savedAccessorProperties) {
- var combinedList = savedAccessorProperties.slice(0);
+ var propertiesMap = new Map();
+ var propertySymbols = [];
+ for (var i = 0; i < savedAccessorProperties.length; i++) {
+ var property = savedAccessorProperties[i];
+ if (property.symbol)
+ propertySymbols.push(property);
+ else
+ propertiesMap.set(property.name, property);
+ }
for (var i = 0; i < savedOwnProperties.length; i++) {
var property = savedOwnProperties[i];
- if (!property.isAccessorProperty())
- combinedList.push(property);
+ if (property.isAccessorProperty())
+ continue;
+ if (property.symbol)
+ propertySymbols.push(property);
+ else
+ propertiesMap.set(property.name, property);
}
- return callback(combinedList, savedInternalProperties ? savedInternalProperties : null);
+ return callback(propertiesMap.valuesArray().concat(propertySymbols), savedInternalProperties ? savedInternalProperties : null);
} else {
callback(null, null);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698