Fixed material design ink drop location for the MD download shelf buttons.

Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual

Review-Url: https://codereview.chromium.org/1915983009
Cr-Commit-Position: refs/heads/master@{#390347}
(cherry picked from commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4)

R=jonross@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/570179660e444a49a8c973eadd3da1f6cd9880df

[bruthig, 2016-05-02 14:42:49]

bruthig@chromium.org changed reviewers:
+ jonross@chromium.org

[bruthig, 2016-05-02 14:42:49]

jonross@, can you please take a quick look?

[bruthig, 2016-05-02 14:45:22]

https://codereview.chromium.org/1942843002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/1942843002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/label_button.cc:420: : make_scoped_ptr(new
views::FloodFillInkDropAnimation(
FYI I this was using a unique_ptr and I changed it to make_scoped_ptr as a part
of a merge conflict.

[jonross, 2016-05-02 14:48:54]

https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_item_view_md.cc:476:
scoped_ptr<views::InkDropAnimation> DownloadItemViewMd::CreateInkDropAnimation()
Please add: #include "base/memory/scoped_ptr.h"

I don't see scoped_ptr elsewhere in the file previously, nor the include

https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
File ui/views/animation/flood_fill_ink_drop_animation.h (right):

https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
ui/views/animation/flood_fill_ink_drop_animation.h:51:
FloodFillInkDropAnimation(const gfx::Rect& clip_bounds,
No rect include?

[bruthig, 2016-05-02 14:59:35]

jonross@, can you take another look?

https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_item_view_md.cc:476:
scoped_ptr<views::InkDropAnimation> DownloadItemViewMd::CreateInkDropAnimation()
On 2016/05/02 14:48:54, jonross wrote:
> Please add: #include "base/memory/scoped_ptr.h"
> 
> I don't see scoped_ptr elsewhere in the file previously, nor the include

Done.

https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
File ui/views/animation/flood_fill_ink_drop_animation.h (right):

https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
ui/views/animation/flood_fill_ink_drop_animation.h:51:
FloodFillInkDropAnimation(const gfx::Rect& clip_bounds,
On 2016/05/02 14:48:54, jonross wrote:
> No rect include?

Added.

[jonross, 2016-05-02 15:08:00]

On 2016/05/02 14:59:35, bruthig wrote:
> jonross@, can you take another look?
> 
>
https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
> File chrome/browser/ui/views/download/download_item_view_md.cc (right):
> 
>
https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views...
> chrome/browser/ui/views/download/download_item_view_md.cc:476:
> scoped_ptr<views::InkDropAnimation>
DownloadItemViewMd::CreateInkDropAnimation()
> On 2016/05/02 14:48:54, jonross wrote:
> > Please add: #include "base/memory/scoped_ptr.h"
> > 
> > I don't see scoped_ptr elsewhere in the file previously, nor the include
> 
> Done.
> 
>
https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
> File ui/views/animation/flood_fill_ink_drop_animation.h (right):
> 
>
https://codereview.chromium.org/1942843002/diff/40001/ui/views/animation/floo...
> ui/views/animation/flood_fill_ink_drop_animation.h:51:
> FloodFillInkDropAnimation(const gfx::Rect& clip_bounds,
> On 2016/05/02 14:48:54, jonross wrote:
> > No rect include?
> 
> Added.

LGTM

[bruthig, 2016-05-02 15:15:34]

Description was changed from

==========
Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual

Review-Url: https://codereview.chromium.org/1915983009
Cr-Commit-Position: refs/heads/master@{#390347}
(cherry picked from commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4)
==========

to

==========
Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual

Review-Url: https://codereview.chromium.org/1915983009
Cr-Commit-Position: refs/heads/master@{#390347}
(cherry picked from commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4)

R=jonross@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/570179660e444a49a8c973eadd3d...
==========

[bruthig, 2016-05-02 15:15:36]

Committed patchset #4 (id:60001) manually as
570179660e444a49a8c973eadd3da1f6cd9880df (tree was closed).