Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1942843002: Fixed material design ink drop location for the MD download shelf buttons. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
jonross
CC:
chromium-reviews, asanka, tfarina, dcheng, bruthig+ink_drop_chromium.org, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fixed material design ink drop location for the MD download shelf buttons. A recent regression caused the clip bounds for the FloodFillInkDropAnimation to incorrectly be centered on the click point for the DownloadItemViewMd buttons. This change fixes that and suppresses the ripple for right clicks on the DownloadItemViewMd as well. BUG=603818 TEST=manual Review-Url: https://codereview.chromium.org/1915983009 Cr-Commit-Position: refs/heads/master@{#390347} (cherry picked from commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4) R=jonross@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/570179660e444a49a8c973eadd3da1f6cd9880df

Patch Set 1 #

Patch Set 2 : Replaced uniqe_ptr with scoped_ptr. #

Total comments: 1

Patch Set 3 : Added scoped_ptr include. #

Total comments: 4

Patch Set 4 : Added some missing includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -49 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 6 chunks +23 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 2 3 3 chunks +11 lines, -7 lines 0 comments Download
M ui/views/animation/flood_fill_ink_drop_animation.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/animation/flood_fill_ink_drop_animation.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M ui/views/animation/ink_drop_animation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bruthig
jonross@, can you please take a quick look?
4 years, 7 months ago (2016-05-02 14:42:49 UTC) #2
bruthig
https://codereview.chromium.org/1942843002/diff/20001/ui/views/controls/button/label_button.cc File ui/views/controls/button/label_button.cc (right): https://codereview.chromium.org/1942843002/diff/20001/ui/views/controls/button/label_button.cc#newcode420 ui/views/controls/button/label_button.cc:420: : make_scoped_ptr(new views::FloodFillInkDropAnimation( FYI I this was using a ...
4 years, 7 months ago (2016-05-02 14:45:22 UTC) #3
jonross
https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode476 chrome/browser/ui/views/download/download_item_view_md.cc:476: scoped_ptr<views::InkDropAnimation> DownloadItemViewMd::CreateInkDropAnimation() Please add: #include "base/memory/scoped_ptr.h" I don't see ...
4 years, 7 months ago (2016-05-02 14:48:54 UTC) #4
bruthig
jonross@, can you take another look? https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views/download/download_item_view_md.cc File chrome/browser/ui/views/download/download_item_view_md.cc (right): https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views/download/download_item_view_md.cc#newcode476 chrome/browser/ui/views/download/download_item_view_md.cc:476: scoped_ptr<views::InkDropAnimation> DownloadItemViewMd::CreateInkDropAnimation() On ...
4 years, 7 months ago (2016-05-02 14:59:35 UTC) #5
jonross
On 2016/05/02 14:59:35, bruthig wrote: > jonross@, can you take another look? > > https://codereview.chromium.org/1942843002/diff/40001/chrome/browser/ui/views/download/download_item_view_md.cc ...
4 years, 7 months ago (2016-05-02 15:08:00 UTC) #6
bruthig
4 years, 7 months ago (2016-05-02 15:15:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
570179660e444a49a8c973eadd3da1f6cd9880df (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698