Fixed material design ink drop location for the MD download shelf buttons.

Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual

Committed: https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4
Cr-Commit-Position: refs/heads/master@{#390347}

[bruthig, 2016-04-27 20:37:51]

bruthig@chromium.org changed reviewers:
+ estade@chromium.org

[bruthig, 2016-04-27 20:37:52]

estade@, can you take a first look?

[Evan Stade, 2016-04-27 23:10:45]

https://codereview.chromium.org/1915983009/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/1915983009/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:252:
CalculateInkDropBounds(size()), 0, GetInkDropBaseColor()));
Do we need the new InkDropHover ctor? Why not

new views::InkDropHover(CalculateInkDropBounds(size()).size(), 0,
GetInkDropCenter(), GetInkDropBaseColor()))

I think it's confusing that you have two ways of doing the exact same thing.

[bruthig, 2016-04-27 23:36:28]

estade@, PTAL

https://codereview.chromium.org/1915983009/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/1915983009/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:252:
CalculateInkDropBounds(size()), 0, GetInkDropBaseColor()));
On 2016/04/27 23:10:44, Evan Stade wrote:
> Do we need the new InkDropHover ctor? Why not
> 
> new views::InkDropHover(CalculateInkDropBounds(size()).size(), 0,
> GetInkDropCenter(), GetInkDropBaseColor()))
> 
> I think it's confusing that you have two ways of doing the exact same thing.

Done.

[Evan Stade, 2016-04-27 23:51:22]

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/floo...
File ui/views/animation/flood_fill_ink_drop_animation.cc (right):

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/floo...
ui/views/animation/flood_fill_ink_drop_animation.cc:113: :
FloodFillInkDropAnimation(gfx::Rect(size), center_point, color) {}
It looks like you can get rid of this one as well if you update just a couple
places we use size() --- instead, use GetLocalBounds().

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_hover.h (right):

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_hover.h:15: #include "ui/gfx/geometry/rect.h"
remove

[bruthig, 2016-04-28 00:04:40]

estade@, PTAL

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/floo...
File ui/views/animation/flood_fill_ink_drop_animation.cc (right):

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/floo...
ui/views/animation/flood_fill_ink_drop_animation.cc:113: :
FloodFillInkDropAnimation(gfx::Rect(size), center_point, color) {}
On 2016/04/27 23:51:22, Evan Stade wrote:
> It looks like you can get rid of this one as well if you update just a couple
> places we use size() --- instead, use GetLocalBounds().

Done.

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_hover.h (right):

https://codereview.chromium.org/1915983009/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_hover.h:15: #include "ui/gfx/geometry/rect.h"
On 2016/04/27 23:51:22, Evan Stade wrote:
> remove

Done.

[Evan Stade, 2016-04-28 00:08:44]

lgtm

[bruthig, 2016-04-28 00:13:04]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2016-04-28 00:13:04]

sky@, can you PTAL?

[sky, 2016-04-28 02:37:20]

LGT

[sky, 2016-04-28 02:37:28]

Make that LGTM

[bruthig, 2016-04-28 11:34:42]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-04-28 11:34:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915983009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915983009/40001

[commit-bot: I haz the power, 2016-04-28 11:39:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:17:31]

Patchset 3 (id:??) landed as
https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4
Cr-Commit-Position: refs/heads/master@{#390347}

[commit-bot: I haz the power, 2016-04-30 17:55:10]

Description was changed from

==========
Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual
==========

to

==========
Fixed material design ink drop location for the MD download shelf buttons.

A recent regression caused the clip bounds for the
FloodFillInkDropAnimation to incorrectly be centered on the click point
for the DownloadItemViewMd buttons. This change fixes that and
suppresses the ripple for right clicks on the DownloadItemViewMd as
well.

BUG=603818
TEST=manual

Committed: https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4
Cr-Commit-Position: refs/heads/master@{#390347}
==========