media/renderers/audio_renderer_impl.h - Issue 1942803002: Caching AudioOutputDevice instances in mixer manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/audio_renderer_impl.h

Issue 1942803002: Caching AudioOutputDevice instances in mixer manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, fix for sleep() compile error on win and a bit of cleanup around timeouts. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/audio_renderer_mixer_input.h ('K') | « media/mojo/services/test_mojo_media_client.cc ('k') | media/renderers/audio_renderer_impl.cc » ('j') | media/renderers/audio_renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/renderers/audio_renderer_impl.h

diff --git a/media/renderers/audio_renderer_impl.h b/media/renderers/audio_renderer_impl.h

index f6d22237d08833a888c95049796d0e3fe2ef1b92..fde50ed9e9792ae7d453dd083836bdb996bc1772 100644

--- a/media/renderers/audio_renderer_impl.h

+++ b/media/renderers/audio_renderer_impl.h

@@ -64,7 +64,6 @@ class MEDIA_EXPORT AudioRendererImpl

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,

AudioRendererSink* sink,

ScopedVector<AudioDecoder> decoders,

- const AudioHardwareConfig& hardware_config,

const scoped_refptr<MediaLog>& media_log);

~AudioRendererImpl() override;

@@ -207,12 +206,9 @@ class MEDIA_EXPORT AudioRendererImpl

std::unique_ptr<AudioBufferStream> audio_buffer_stream_;

- // Interface to the hardware audio params.

- const AudioHardwareConfig& hardware_config_;

scoped_refptr<MediaLog> media_log_;

- // Cached copy of hardware params from |hardware_config_|.

+ // Cached copy of hardware params from |sink_|.

AudioParameters audio_parameters_;

// Callbacks provided during Initialize().