Caching AudioOutputDevice instances in mixer manager

media/renderers/audio_renderer_impl.cc

Index: media/renderers/audio_renderer_impl.cc
diff --git a/media/renderers/audio_renderer_impl.cc b/media/renderers/audio_renderer_impl.cc
index bda439c5e59075325bd72eaf4b8aa84f25cc5647..5e3dee5bc066ffb2b37e169c112b879a06b975d0 100644
--- a/media/renderers/audio_renderer_impl.cc
+++ b/media/renderers/audio_renderer_impl.cc
@@ -35,14 +35,12 @@ AudioRendererImpl::AudioRendererImpl(
     const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
     media::AudioRendererSink* sink,
     ScopedVector<AudioDecoder> decoders,
-    const AudioHardwareConfig& hardware_config,
     const scoped_refptr<MediaLog>& media_log)
     : task_runner_(task_runner),
       expecting_config_changes_(false),
       sink_(sink),
       audio_buffer_stream_(
           new AudioBufferStream(task_runner, std::move(decoders), media_log)),
-      hardware_config_(hardware_config),
       media_log_(media_log),
       tick_clock_(new base::DefaultTickClock()),
       last_audio_memory_usage_(0),
@@ -343,7 +341,8 @@ void AudioRendererImpl::Initialize(
   error_cb_ = error_cb;
   statistics_cb_ = statistics_cb;
 
-  const AudioParameters& hw_params = hardware_config_.GetOutputConfig();
+  const AudioParameters& hw_params =
+      sink_->GetOutputDeviceInfo().output_params();
   expecting_config_changes_ = stream->SupportsConfigChanges();
   if (!expecting_config_changes_ || !hw_params.IsValid() ||

[Guido Urdaneta, 2016/05/11 10:49:29]

Should we also check if GetOutputDeviceInfo().device_status() != OK?

[o1ka, 2016/05/11 11:47:10]

Good question. If the status is not OK, we won't get any render callbacks, so
the fact that we don't check it is not a problem; it makes sense to skip the
initialization though. I'll leave that for a follow-up CL which will remove HW
config usage everywhere, as we discussed.

       hw_params.format() == AudioParameters::AUDIO_FAKE) {