Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1942733002: Revert of [turbofan] Remove left-over change bits from ChangeLowering. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Remove left-over change bits from ChangeLowering. (patchset #2 id:20001 of https://codereview.chromium.org/1941673002/ ) Reason for revert: [Sheriff] Breaks mac gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/5821 Original issue's description: > [turbofan] Remove left-over change bits from ChangeLowering. > > Now ChangeLowering is only concerned with lowering memory access and > allocation operations, and all changes are consistently lowered during > the effect/control linearization pass. The next step is to move the > left over lowerings to a pass dedicated to eliminate redundant loads and > stores, eliminate write barriers, fold and inline allocations. > > Also remove the atomic regions now that we wire everything into the > effect chain properly. This is an important step towards allocation > inlining. > > Drive-by-fix: Rename ChangeBitToBool to ChangeBitToTagged, > ChangeBoolToBit to ChangeTaggedToBit, and ChangeInt31ToTagged to > ChangeInt31ToTaggedSigned for consistency. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > Committed: https://crrev.com/ceca5ae308bddda166651c654f96d71d74f617d0 > Cr-Commit-Position: refs/heads/master@{#35924} TBR=ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b4c3864ba4e00a7572ada083a90461d6a059a453 Cr-Commit-Position: refs/heads/master@{#35927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -186 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 4 chunks +67 lines, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 18 chunks +24 lines, -100 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/verifier.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +5 lines, -5 lines 0 comments Download
A test/cctest/compiler/test-changes-lowering.cc View 1 chunk +183 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +33 lines, -27 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [turbofan] Remove left-over change bits from ChangeLowering.
4 years, 7 months ago (2016-05-02 09:28:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942733002/1
4 years, 7 months ago (2016-05-02 09:28:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 09:28:52 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 09:29:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4c3864ba4e00a7572ada083a90461d6a059a453
Cr-Commit-Position: refs/heads/master@{#35927}

Powered by Google App Engine
This is Rietveld 408576698