Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/verifier.cc

Issue 1942733002: Revert of [turbofan] Remove left-over change bits from ChangeLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 } 796 }
797 case IrOpcode::kChangeTaggedToFloat64: { 797 case IrOpcode::kChangeTaggedToFloat64: {
798 // Number /\ Tagged -> Number /\ UntaggedFloat64 798 // Number /\ Tagged -> Number /\ UntaggedFloat64
799 // TODO(neis): Activate once ChangeRepresentation works in typer. 799 // TODO(neis): Activate once ChangeRepresentation works in typer.
800 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 800 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
801 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedFloat64()); 801 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedFloat64());
802 // CheckValueInputIs(node, 0, from)); 802 // CheckValueInputIs(node, 0, from));
803 // CheckUpperIs(node, to)); 803 // CheckUpperIs(node, to));
804 break; 804 break;
805 } 805 }
806 case IrOpcode::kChangeInt31ToTaggedSigned: { 806 case IrOpcode::kChangeInt31ToTagged: {
807 // Signed31 /\ UntaggedInt32 -> Signed31 /\ Tagged 807 // Signed31 /\ UntaggedInt32 -> Signed31 /\ Tagged
808 // TODO(neis): Activate once ChangeRepresentation works in typer. 808 // TODO(neis): Activate once ChangeRepresentation works in typer.
809 // Type* from =Type::Intersect(Type::Signed31(), Type::UntaggedInt32()); 809 // Type* from =Type::Intersect(Type::Signed31(), Type::UntaggedInt32());
810 // Type* to = Type::Intersect(Type::Signed31(), Type::Tagged()); 810 // Type* to = Type::Intersect(Type::Signed31(), Type::Tagged());
811 // CheckValueInputIs(node, 0, from)); 811 // CheckValueInputIs(node, 0, from));
812 // CheckUpperIs(node, to)); 812 // CheckUpperIs(node, to));
813 break; 813 break;
814 } 814 }
815 case IrOpcode::kChangeInt32ToTagged: { 815 case IrOpcode::kChangeInt32ToTagged: {
816 // Signed32 /\ UntaggedInt32 -> Signed32 /\ Tagged 816 // Signed32 /\ UntaggedInt32 -> Signed32 /\ Tagged
(...skipping 15 matching lines...) Expand all
832 } 832 }
833 case IrOpcode::kChangeFloat64ToTagged: { 833 case IrOpcode::kChangeFloat64ToTagged: {
834 // Number /\ UntaggedFloat64 -> Number /\ Tagged 834 // Number /\ UntaggedFloat64 -> Number /\ Tagged
835 // TODO(neis): Activate once ChangeRepresentation works in typer. 835 // TODO(neis): Activate once ChangeRepresentation works in typer.
836 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64()); 836 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64());
837 // Type* to = Type::Intersect(Type::Number(), Type::Tagged()); 837 // Type* to = Type::Intersect(Type::Number(), Type::Tagged());
838 // CheckValueInputIs(node, 0, from)); 838 // CheckValueInputIs(node, 0, from));
839 // CheckUpperIs(node, to)); 839 // CheckUpperIs(node, to));
840 break; 840 break;
841 } 841 }
842 case IrOpcode::kChangeTaggedToBit: { 842 case IrOpcode::kChangeBoolToBit: {
843 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1 843 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1
844 // TODO(neis): Activate once ChangeRepresentation works in typer. 844 // TODO(neis): Activate once ChangeRepresentation works in typer.
845 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr()); 845 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr());
846 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1()); 846 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1());
847 // CheckValueInputIs(node, 0, from)); 847 // CheckValueInputIs(node, 0, from));
848 // CheckUpperIs(node, to)); 848 // CheckUpperIs(node, to));
849 break; 849 break;
850 } 850 }
851 case IrOpcode::kChangeBitToTagged: { 851 case IrOpcode::kChangeBitToBool: {
852 // Boolean /\ UntaggedInt1 -> Boolean /\ TaggedPtr 852 // Boolean /\ UntaggedInt1 -> Boolean /\ TaggedPtr
853 // TODO(neis): Activate once ChangeRepresentation works in typer. 853 // TODO(neis): Activate once ChangeRepresentation works in typer.
854 // Type* from = Type::Intersect(Type::Boolean(), Type::UntaggedInt1()); 854 // Type* from = Type::Intersect(Type::Boolean(), Type::UntaggedInt1());
855 // Type* to = Type::Intersect(Type::Boolean(), Type::TaggedPtr()); 855 // Type* to = Type::Intersect(Type::Boolean(), Type::TaggedPtr());
856 // CheckValueInputIs(node, 0, from)); 856 // CheckValueInputIs(node, 0, from));
857 // CheckUpperIs(node, to)); 857 // CheckUpperIs(node, to));
858 break; 858 break;
859 } 859 }
860 case IrOpcode::kTruncateTaggedToWord32: { 860 case IrOpcode::kTruncateTaggedToWord32: {
861 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 861 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
1354 replacement->op()->EffectOutputCount() > 0); 1354 replacement->op()->EffectOutputCount() > 0);
1355 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1355 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1356 replacement->opcode() == IrOpcode::kFrameState); 1356 replacement->opcode() == IrOpcode::kFrameState);
1357 } 1357 }
1358 1358
1359 #endif // DEBUG 1359 #endif // DEBUG
1360 1360
1361 } // namespace compiler 1361 } // namespace compiler
1362 } // namespace internal 1362 } // namespace internal
1363 } // namespace v8 1363 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698