Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194273004: Check if input element is a range control before painting slider ticks (Closed)

Created:
6 years, 9 months ago by keishi
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Check if input element is a range control before painting slider ticks We weren't checking if the input element is a range control inside paintSliderTicks and so we were hitting an assert. TEST=Automated. Added slider-appearance-with-ticks-crash.html. BUG=350905 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169936

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : moved test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A LayoutTests/fast/forms/datalist/slider-appearance-with-ticks-crash.html View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/datalist/slider-appearance-with-ticks-crash-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
keishi
6 years, 9 months ago (2014-03-11 06:38:37 UTC) #1
tkent
lgtm https://codereview.chromium.org/194273004/diff/20001/LayoutTests/fast/forms/slider-appearance-with-ticks-crash.html File LayoutTests/fast/forms/slider-appearance-with-ticks-crash.html (right): https://codereview.chromium.org/194273004/diff/20001/LayoutTests/fast/forms/slider-appearance-with-ticks-crash.html#newcode1 LayoutTests/fast/forms/slider-appearance-with-ticks-crash.html:1: <!DOCTYPE html> Please move this to fast/forms/datalist/ or ...
6 years, 9 months ago (2014-03-11 06:42:48 UTC) #2
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 9 months ago (2014-03-12 02:06:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/194273004/40001
6 years, 9 months ago (2014-03-12 02:06:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 02:44:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-12 02:44:04 UTC) #6
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 9 months ago (2014-03-25 11:19:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/194273004/40001
6 years, 9 months ago (2014-03-25 11:19:46 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 12:22:11 UTC) #9
Message was sent while issue was closed. 
Change committed as 169936

Powered by Google App Engine
This is Rietveld 408576698