Source/core/rendering/RenderTheme.cpp - Issue 194273004: Check if input element is a range control before painting slider ticks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.cpp

Issue 194273004: Check if input element is a range control before painting slider ticks (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: moved test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTheme.cpp

diff --git a/Source/core/rendering/RenderTheme.cpp b/Source/core/rendering/RenderTheme.cpp

index d7aa06f9ecdf21f317589ff4cc357d998de3340f..5c427b93021b57137e39d1e21ae7b1f8a55a5f9a 100644

--- a/Source/core/rendering/RenderTheme.cpp

+++ b/Source/core/rendering/RenderTheme.cpp

@@ -868,6 +868,9 @@ void RenderTheme::paintSliderTicks(RenderObject* o, const PaintInfo& paintInfo,

return;

HTMLInputElement* input = toHTMLInputElement(node);

+ if (!input->isRangeControl())

+ return;

HTMLDataListElement* dataList = input->dataList();

if (!dataList)

return;

« no previous file with comments | « LayoutTests/fast/forms/datalist/slider-appearance-with-ticks-crash-expected.txt ('k') | no next file » | no next file with comments »