Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1942613002: Change semicolon replace logic in url_fixer (Closed)

Created:
4 years, 7 months ago by Alexander Yashkin
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change semicolon replace logic in url_fixer This change adds additional check to url_fixer logic while trying to fix user input. New implementation tries to change ';' to ':'in SegmentURLInternal only for known url schemes. BUG=606341 R=pkasting@chromium.org, grt@chromium.org Committed: https://crrev.com/3abb13a381810cba427d7175eb4fa7862ee0d2d0 Cr-Commit-Position: refs/heads/master@{#391172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M components/omnibox/browser/autocomplete_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_formatter/url_fixer.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M components/url_formatter/url_fixer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexander Yashkin
4 years, 7 months ago (2016-04-30 16:41:08 UTC) #1
Peter Kasting
LGTM
4 years, 7 months ago (2016-05-03 01:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942613002/1
4 years, 7 months ago (2016-05-03 04:39:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 05:36:53 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:38:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3abb13a381810cba427d7175eb4fa7862ee0d2d0
Cr-Commit-Position: refs/heads/master@{#391172}

Powered by Google App Engine
This is Rietveld 408576698