Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1887)

Unified Diff: components/url_formatter/url_fixer_unittest.cc

Issue 1942613002: Change semicolon replace logic in url_fixer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/url_formatter/url_fixer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/url_formatter/url_fixer_unittest.cc
diff --git a/components/url_formatter/url_fixer_unittest.cc b/components/url_formatter/url_fixer_unittest.cc
index 01b1c3c04adf67f8635b31ec47575910a681ce60..a425489494e7651b4e710e3b35d1ea586f73de80 100644
--- a/components/url_formatter/url_fixer_unittest.cc
+++ b/components/url_formatter/url_fixer_unittest.cc
@@ -302,8 +302,8 @@ struct FixupCase {
// Semicolon as scheme separator for standard schemes.
{"http;//www.google.com/", "http://www.google.com/"},
{"about;chrome", "chrome://chrome/"},
- // Semicolon left as-is for non-standard schemes.
- {"whatsup;//fool", "whatsup://fool"},
+ // Semicolon in non-standard schemes is not replaced by colon.
+ {"whatsup;//fool", "http://whatsup%3B//fool"},
// Semicolon left as-is in URL itself.
{"http://host/port?query;moar", "http://host/port?query;moar"},
// Fewer slashes than expected.
« no previous file with comments | « components/url_formatter/url_fixer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698