gn: add is_ubsan_no_recover to halt the program on the first problem.

gn: add is_ubsan_no_recover to halt the program on the first problem.

BUG=606003
Committed: https://crrev.com/4e1a01ea5781f1ddce3c38c2d96ba1ba18b95d1a
Cr-Commit-Position: refs/heads/master@{#390841}

[krasin, 2016-04-30 01:36:21]

krasin@google.com changed reviewers:
+ dpranke@google.com

[Dirk Pranke, 2016-04-30 01:38:18]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-30 01:38:19]

lgtm w/ nit.

https://codereview.chromium.org/1942563002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1942563002/diff/20001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:22: # Half the program if a problem is
detected.
s/Half/Halt/

[krasin, 2016-04-30 01:40:49]

https://codereview.chromium.org/1942563002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1942563002/diff/20001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:22: # Half the program if a problem is
detected.
On 2016/04/30 01:38:19, Dirk Pranke wrote:
> s/Half/Halt/

Done.

[krasin, 2016-04-30 01:40:52]

The CQ bit was checked by krasin@google.com

[krasin, 2016-04-30 01:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1942563002/#ps40001
(title: "Half->Halt")

[commit-bot: I haz the power, 2016-04-30 01:41:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942563002/40001

[commit-bot: I haz the power, 2016-04-30 02:51:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:31:05]

Patchset 3 (id:??) landed as
https://crrev.com/4e1a01ea5781f1ddce3c38c2d96ba1ba18b95d1a
Cr-Commit-Position: refs/heads/master@{#390841}

[commit-bot: I haz the power, 2016-04-30 18:04:05]

Description was changed from

==========
gn: add is_ubsan_no_recover to halt the program on the first problem.

BUG=606003
==========

to

==========
gn: add is_ubsan_no_recover to halt the program on the first problem.

BUG=606003

Committed: https://crrev.com/4e1a01ea5781f1ddce3c38c2d96ba1ba18b95d1a
Cr-Commit-Position: refs/heads/master@{#390841}
==========

[Nico, 2016-12-02 22:21:31]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-12-02 22:21:32]

I needed this today and was confused by:

1. This being a negated constant. I think "ubsan_recover" would be much easier
to understand (thinking "_no_recover is false which is a double negation so that
means yes recover" always confuses me)

2. Stopping on the first error not being the default. (This might not be fixable
due to tons of things being broken, but I thought I'd mention it.)

[krasin1, 2016-12-02 22:39:35]

On 2016/12/02 22:21:32, Nico wrote:
> I needed this today and was confused by:
> 
> 1. This being a negated constant. I think "ubsan_recover" would be much easier
> to understand (thinking "_no_recover is false which is a double negation so
that
> means yes recover" always confuses me)
> 
> 2. Stopping on the first error not being the default. (This might not be
fixable
> due to tons of things being broken, but I thought I'd mention it.)

This CL (if I recall correctly) mirrored GYP behavior. Now that GYP is gone, we
can make a change and revert the default behavior and the optional switch as you
have suggested.